From a5bff0c75e77effb5b7d3a1691de1b14bcdbd648 Mon Sep 17 00:00:00 2001
From: Andronik <write@reusable.software>
Date: Tue, 15 Nov 2022 16:26:03 +0100
Subject: [PATCH] remove the runtime check and test

---
 runtime/parachains/src/disputes.rs       |  5 --
 runtime/parachains/src/disputes/tests.rs | 64 ------------------------
 2 files changed, 69 deletions(-)

diff --git a/runtime/parachains/src/disputes.rs b/runtime/parachains/src/disputes.rs
index 9474d21d0d85..439d83d942dd 100644
--- a/runtime/parachains/src/disputes.rs
+++ b/runtime/parachains/src/disputes.rs
@@ -537,8 +537,6 @@ pub mod pallet {
 		PotentialSpam,
 		/// A dispute where there are only votes on one side.
 		SingleSidedDispute,
-		/// No backing votes were provides along dispute statements.
-		MissingBackingVotes,
 	}
 
 	#[pallet::call]
@@ -1232,9 +1230,6 @@ impl<T: Config> Pallet<T> {
 			Error::<T>::SingleSidedDispute,
 		);
 
-		// Reject statements with no accompanying backing votes.
-		ensure!(!backers.is_empty(), Error::<T>::MissingBackingVotes,);
-
 		<BackersOnDisputes<T>>::insert(&set.session, &set.candidate_hash, backers.clone());
 
 		let DisputeStatementSet { ref session, ref candidate_hash, .. } = set;
diff --git a/runtime/parachains/src/disputes/tests.rs b/runtime/parachains/src/disputes/tests.rs
index 7c9aafe66137..3b1f212a38a1 100644
--- a/runtime/parachains/src/disputes/tests.rs
+++ b/runtime/parachains/src/disputes/tests.rs
@@ -737,70 +737,6 @@ fn test_provide_multi_dispute_is_providing() {
 	})
 }
 
-#[test]
-fn test_disputes_with_missing_backing_votes_are_rejected() {
-	new_test_ext(Default::default()).execute_with(|| {
-		let v0 = <ValidatorId as CryptoType>::Pair::generate().0;
-		let v1 = <ValidatorId as CryptoType>::Pair::generate().0;
-
-		run_to_block(3, |b| {
-			// a new session at each block
-			if b == 1 {
-				Some((
-					true,
-					b,
-					vec![(&0, v0.public()), (&1, v1.public())],
-					Some(vec![(&0, v0.public()), (&1, v1.public())]),
-				))
-			} else {
-				Some((true, b, vec![(&1, v1.public())], Some(vec![(&1, v1.public())])))
-			}
-		});
-
-		let candidate_hash = CandidateHash(sp_core::H256::repeat_byte(1));
-		let session = 1;
-
-		let stmts = vec![DisputeStatementSet {
-			candidate_hash: candidate_hash.clone(),
-			session,
-			statements: vec![
-				(
-					DisputeStatement::Valid(ValidDisputeStatementKind::Explicit),
-					ValidatorIndex(0),
-					v0.sign(
-						&ExplicitDisputeStatement {
-							valid: true,
-							candidate_hash: candidate_hash.clone(),
-							session,
-						}
-						.signing_payload(),
-					),
-				),
-				(
-					DisputeStatement::Invalid(InvalidDisputeStatementKind::Explicit),
-					ValidatorIndex(1),
-					v1.sign(
-						&ExplicitDisputeStatement {
-							valid: false,
-							candidate_hash: candidate_hash.clone(),
-							session,
-						}
-						.signing_payload(),
-					),
-				),
-			],
-		}];
-
-		assert!(Pallet::<Test>::process_checked_multi_dispute_data(
-			stmts
-				.into_iter()
-				.map(CheckedDisputeStatementSet::unchecked_from_unchecked)
-				.collect()
-		)
-		.is_err(),);
-	})
-}
-
 #[test]
 fn test_freeze_on_note_included() {
 	new_test_ext(Default::default()).execute_with(|| {