Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF validation host: Do not conflate different errors by child worker #3754

Closed
pepyakin opened this issue Aug 31, 2021 · 2 comments · Fixed by #6384
Closed

PVF validation host: Do not conflate different errors by child worker #3754

pepyakin opened this issue Aug 31, 2021 · 2 comments · Fixed by #6384
Assignees

Comments

@pepyakin
Copy link
Contributor

Right now, the preparation worker conflates different errors into a single DidntMakeIt artifact status. Worse, this is reported by the execution worker as "preparation timeout" which is extremely confusing. Untangling this would be the result of completion of this issue.

At the moment of writing, that error can be reported on the following conditions:

  1. the response from the worker is received, but the file cannot be renamed (moved) to the final destination location
  2. the response from the worker is received, but it is not what we expected
  3. an IO error occurred while receiving the result from the worker process
  4. the worker took too much time to finish preparation

All these issues should be properly reported separately. This means we should probably list those conditions in the ArtifactState enum.

@mrcnski
Copy link
Contributor

mrcnski commented Nov 15, 2022

I noticed this too. Glad there is already an issue for it, I can take this up in the near future. Maybe after #6282 is done to prevent merge conflicts.

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants