Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Whitelist XCM Storage Read Each block from Benchmarking #5203

Closed
shawntabrizi opened this issue Mar 24, 2022 · 4 comments
Closed

Whitelist XCM Storage Read Each block from Benchmarking #5203

shawntabrizi opened this issue Mar 24, 2022 · 4 comments
Assignees
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented Mar 24, 2022

For example:

// Storage: XcmPallet SupportedVersion (r:1 w:0)
// Storage: XcmPallet VersionDiscoveryQueue (r:1 w:1)
// Storage: XcmPallet SafeXcmVersion (r:1 w:0)
// Storage: Configuration ActiveConfig (r:1 w:0)

All of these storage items are read each block, and thus do not also need to be included into the main benchmark weights.

See: #4442

@KiChjang
Copy link
Contributor

I think a7a5387 addresses this.

@KiChjang
Copy link
Contributor

Actually, I didn't add the XCM pallet's storage items, as I wasn't sure if they're really read each block.

@shawntabrizi
Copy link
Member Author

I think the assumption is that you should expect at least one XCM message present each Polkadot block, so yeah, all of them would be whitelisted.

But would be best we actually design this whitelisting in the FRAME macros.

@franciscoaguirre
Copy link
Contributor

This was fixed in #6871

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

3 participants