Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pass motion to enable pre-checking on Kusama + Polkadot #6212

Closed
eskimor opened this issue Oct 30, 2022 · 5 comments
Closed

Pass motion to enable pre-checking on Kusama + Polkadot #6212

eskimor opened this issue Oct 30, 2022 · 5 comments
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Milestone

Comments

@eskimor
Copy link
Member

eskimor commented Oct 30, 2022

Pass motion to enable prechecking.

@bkchr The mentioned go ahead signal: Do you have insights whether this is already honored by all deployed parachains on Polkadot and Kusama?

Prior to this we have to make sure 0.9.30 is rolled on a super majority of validators (the necessary node side changes are contained there).

@slumber how are things looking on Rococo/Westend? Have we enabled yet? - disregard, I just saw the messages. Thanks!

@eskimor eskimor added the T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. label Oct 30, 2022
@eskimor eskimor added this to the slashing milestone Oct 30, 2022
@eskimor eskimor moved this to To do in Parachains-core Oct 30, 2022
@ordian
Copy link
Member

ordian commented Oct 30, 2022

On Rococo, do we need to include Paras::ValidateUnsigned here

Paras: parachains_paras::{Pallet, Call, Storage, Event, Config} = 56,
as Babe does
Babe: pallet_babe::{Pallet, Call, Storage, Config, ValidateUnsigned} = 1,

#[pallet::validate_unsigned]
impl<T: Config> ValidateUnsigned for Pallet<T> {

@eskimor
Copy link
Member Author

eskimor commented Oct 30, 2022

I am confused, aren't we using the Rococo runtime on Versi? Hence how did this work on Versi if it now fails on Rococo?

@eskimor
Copy link
Member Author

eskimor commented Oct 30, 2022

Ok, Polkadot and Kusama need this as well. This means we need another runtime upgrade before being able to enable it. Ok, I'll make a PR.

@eskimor
Copy link
Member Author

eskimor commented Oct 30, 2022

#6214

@bkchr
Copy link
Member

bkchr commented Nov 1, 2022

@bkchr The mentioned go ahead signal: Do you have insights whether this is already honored by all deployed parachains on Polkadot and Kusama?

I think this was rolled out quite some time ago. Aka it should be already available on all parachains.

@eskimor eskimor removed this from Parachains-core Jan 5, 2023
@eskimor eskimor moved this from Todo to Waiting for in Disputes + Slashing + Rewards Jan 5, 2023
@eskimor eskimor moved this from Waiting for to Done in Disputes + Slashing + Rewards Feb 14, 2023
@eskimor eskimor closed this as completed Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Development

No branches or pull requests

3 participants