This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
overseer: send_msg should not return an error #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Improve collator side of the collator-protocol (#1955)
ordian
added
A0-please_review
github-actions
bot
added
A3-in_progress
ordian
added
A0-please_review
bkchr
reviewed
Nov 23, 2020
| where T: IntoIterator<Item = AllMessages> + Send, T::IntoIter: Send | ||
| { | ||
| let mut msgs = stream::iter(msgs.into_iter().map(ToOverseer::SubsystemMessage).map(Ok)); | ||
| self.tx.send_all(&mut msgs).await.map_err(Into::into) | ||
| if self.tx.send_all(&mut msgs).await.is_err() { |
There was a problem hiding this comment.
Sending can only fail when the overseer has closed the channel. Do we really need to log this?
There was a problem hiding this comment.
This can be helpful for debugging purposes when running tests. Normally we should not see it fail when if the overseer sends Conclude signal in test environment. I can downgrade the log level to debug though.
node/overseer/src/lib.rs
Outdated
| } | ||
|
|
||
| impl<M> OverseerSubsystemContext<M> { | ||
| async fn send_logging_error(&mut self, msg: ToOverseer) { |
|
|
||
| impl<M> OverseerSubsystemContext<M> { | ||
| async fn send_logging_error(&mut self, msg: ToOverseer) { | ||
| if self.tx.send(msg).await.is_err() { |
ordian
commented
Nov 23, 2020
ordian
commented
Nov 23, 2020
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
bkchr
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602 (comment).