Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

past-session validator discovery APIs #2009

Merged
43 commits merged into from
Nov 26, 2020
Merged

past-session validator discovery APIs #2009

43 commits merged into from
Nov 26, 2020

Conversation

ordian
Copy link
Member

@ordian ordian commented Nov 24, 2020

Fixes #1461.

On top of #1968.

@ordian
guide: fix formatting for SessionInfo module
4fecb64
@ordian
primitives: SessionInfo type
f3b5430
@ordian
punt on approval keys
62843e9
@ordian
ah, revert the type alias
1f720aa
@ordian
session info runtime module skeleton
25dd0c9
@ordian
update the guide
f1dd12a
@ordian
runtime/configuration: sync with the guide
b2ef662
@ordian
runtime/configuration: setters for newly added fields
c2512be
@ordian
runtime/configuration: set codec indexes
a6432bf
@ordian
runtime/configuration: update test
d350875
@ordian
primitives: fix SessionInfo definition
93e29b2
@ordian
runtime/session_info: initial impl
4a5ca12
@ordian
runtime/session_info: use initializer for session handling (wip)
e594e5d
@ordian
Merge branch 'master' into ao-session-info
c9f4e7c 
* master:
  Bump smallvec from 1.4.2 to 1.5.0 (#1971)
  Companion PR for substrate#7549 (#1967)
  Bump parking_lot from 0.11.0 to 0.11.1 (#1970)
  Connect to different validators on different leaves (#1966)
  patches (#1965)
  Bump dlmalloc from 0.1.4 to 0.2.1 (#1962)
@ordian
Merge branch 'master' into ao-session-info
d308491 
* master:
  base priority on client changes only (#1969)
@ordian
runtime/session_info: mock authority discovery trait
b01341a
@ordian
guide: update the initializer's order
2e563d3
@ordian
runtime/session_info: tests skeleton
532429e
@ordian
runtime/session_info: store n_delay_tranches in Configuration
b0dd493
@ordian
runtime/session_info: punt on approval keys
ca9dd13
@ordian
runtime/session_info: add some basic tests
088efb3
@ordian
Merge branch 'master' into ao-session-info
4599423 
* master:
  A simple check to reject obviously wrong validation code binaries (#1989)
  fix approval keytypes doc (#1988)
  add max_pov_size to runtime config and PersistedValidationData (#1984)
  Bump env_logger from 0.8.1 to 0.8.2 (#1981)
  Bump pin-project from 1.0.1 to 1.0.2 (#1982)
@ordian
Update primitives/src/v1.rs
76ec9ab
@ordian
small fixes
f8a11cb
@ordian
remove codec index annotation on structs
2f6905a
@ordian
Merge branch 'master' into ao-session-info
d50073b 
* master:
  Improve collator side of the collator-protocol (#1955)
  add parity-keyring to install instructions (#1993)
  sane messaging defaults (#1994)
  cleanup validator discovery (#1992)
  Add Prometheus timers to the subsystems (#1923)
  Add tracing support to node (#1940)
@ordian
Merge branch 'master' into ao-session-info
612c170 
* master:
  overseer: send_msg should not return an error (#1995)
  Bump async-trait from 0.1.41 to 0.1.42 (#1996)
@ordian
fix off-by-one error
35cb563
@ordian
validator_discovery: accept a session index
3d22556
@ordian
runtime: replace validator_discovery api with session_info
5304563
@ordian
Merge branch 'master' into ao-validator-discovery-previous-sessions
60aede3 
* master:
  backing: reorder votes to match bitfield in backed candidate (#2006)
  Switch to wasm-builder 3.0.0 (#2004)
  Make sure we inform statement listeners about received statements (#1999)
  Update docker.md (#2000)
  Bump tracing from 0.1.21 to 0.1.22 (#2001)
  Bump assert_cmd from 1.0.1 to 1.0.2 (#2003)
  Bump color-eyre from 0.5.7 to 0.5.8 (#2002)
  *: Update authority discovery and remove WorkerConfig (#1953)
  companion for substrate#7546 (#1954)
@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 24, 2020
coriolinus
coriolinus approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed from 3d22556 on; I believe that to be the start of this PR.

node/network/collator-protocol/src/collator_side.rs Outdated Show resolved Hide resolved
node/subsystem-util/src/lib.rs Show resolved Hide resolved
ordian and others added 10 commits November 25, 2020 13:33
@ordian @pepyakin
Update runtime/parachains/src/session_info.rs
21eb2a4 
Co-authored-by: Sergei Shulepov <sergei@parity.io>
@ordian
runtime/session_info: add a comment about missing entries
25e13e1
@ordian
runtime/session_info: define the keys
158a5fa
@ordian
Merge branch 'ao-session-info' into ao-validator-discovery-previous-s…
8c32d84 
…essions

* ao-session-info:
  runtime/session_info: define the keys
  runtime/session_info: add a comment about missing entries
  Update runtime/parachains/src/session_info.rs
@ordian
util: expose connect_to_past_session_validators
09c9359
@ordian
util: allow session_info requests for jobs
1d7ad3b
@ordian
runtime-api: add mock test for session_info
992ed07
@ordian
collator-protocol: add session_index to test state
835ae2f
@ordian
Merge branch 'master' into ao-validator-discovery-previous-sessions
f1cc838 
* master:
  Some code cleanup in overseer (#2008)
  PoV Distribution optimization (#1990)
  Approval Distribution Subsystem (#1951)
  Session management for approval voting (#1973)
  Do not send messages twice in bitfield distribution (#2005)
@ordian
util: fix error message for runtime error
248fd37
@ordian
Copy link
Member Author

ordian commented Nov 25, 2020

This PR removes validator_discovery runtime API call in favor of session_info (+ session_index_for_child to retrieve the current session index). I think it's redundant now, but if you disagree I can bring it back.

@ordian ordian requested a review from montekki November 25, 2020 17:21
@montekki
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Nov 26, 2020

Trying merge.

@ghost ghost merged commit 734eda8 into master Nov 26, 2020
@ghost ghost deleted the ao-validator-discovery-previous-sessions branch November 26, 2020 11:02
This was referenced Nov 26, 2020
Closed
Closed
@ordian ordian mentioned this pull request Sep 27, 2022
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@montekki montekki montekki approved these changes

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement past-session validator discovery APIs for Network Bridge
3 participants
@ordian @montekki @coriolinus