Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for impl Zero and One for fixed point numbers #2922

Closed
wants to merge 1 commit into from
Closed

Companion for impl Zero and One for fixed point numbers #2922

wants to merge 1 commit into from

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Apr 22, 2021

@xlc xlc mentioned this pull request Apr 22, 2021
Merged
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 22, 2021
@ghost
Copy link

ghost commented Apr 22, 2021

Error: Companion update failed: Command 'Command { std: "git" "push" "AcalaNetwork" "zero-and-one", kill_on_drop: false }' failed with status Some(128); output: remote: Permission to AcalaNetwork/polkadot.git denied to parity-processbot[bot].
fatal: unable to access 'https://x-access-token:${SECRET}@github.com/AcalaNetwork/polkadot.git/': The requested URL returned error: 403

@shawntabrizi shawntabrizi mentioned this pull request Apr 23, 2021
Merged
@shawntabrizi
Copy link
Member

@xlc need to cargo update -p sp-io

@shawntabrizi
Copy link
Member

Merged the other PR.

@xlc make sure you turn on the setting so that parity people can contribute to the pr 🤷‍♂️

@xlc xlc deleted the zero-and-one branch April 23, 2021 04:17
@xlc
Copy link
Contributor Author

xlc commented Apr 23, 2021

Humm I always thought it is enabled by default. I can't even see that setting in this screen...

@joao-paulo-parity
Copy link
Contributor

Hey @xlc, bot maintainer here. Apparently this is a Github limitation reported in isaacs/github#1681. I think that is why you don't see the setting. Sorry about that.

Probably would work if were to submit the PR from your own account's fork rather than the organization's, but it's understandable if you don't want to do that.

@joao-paulo-parity joao-paulo-parity mentioned this pull request Apr 23, 2021
Open
@xlc
Copy link
Contributor Author

xlc commented Apr 23, 2021

oh good to know. will do from my personal account next time

@joao-paulo-parity joao-paulo-parity mentioned this pull request Jun 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xlc @shawntabrizi @joao-paulo-parity @bkchr