This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dispute Coordinator: Move to batch Request - Response model #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves to batch queries when responding to QueryCandidateVotes messages. This simplifies the code in the provisioner and dispute-coordinator by no longer requiring to make use of a FuturesOrdered when awaiting multiple quries. Instead, the provisioner need only request the batch itself.
Lldenaurois
added
A0-please_review
rphmeier
reviewed
Jul 8, 2021
|
|
||
| vote_sets | ||
| rx.await.unwrap_or_default().into_iter().zip(recent_disputes.into_iter()) |
There was a problem hiding this comment.
I'd like a debug! log as done above
rphmeier
reviewed
Jul 8, 2021
| let _ = rx.send(candidate_votes.map(Into::into)); | ||
| let mut query_output = Vec::new(); | ||
| for (session_index, candidate_hash) in query.into_iter() { | ||
| if let Some(v) = db::v1::load_candidate_votes( |
There was a problem hiding this comment.
It would be better to fail the request if any of the votes aren't present. As such, the zip done in the provisioner is inaccurate.
rphmeier
suggested changes
Jul 8, 2021
ghost
closed this
ghost
deleted the branch
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the communication protocol between the provisioner and the dispute-coordinator. In the past, the dispute-coordinator kept track of a FuturesOrdered of oneshot-receivers and constructed a view of the recent disputes in this fashion.
Instead, it is more efficient to allow batch queries and only iterator over the recent disputes once. We leverage a single oneshot channel to reply to the batch
Vec<(SessionIndex, CandidateHash)>request with theVec<(SessionIndex, Candidatehash, CandidateVotes)>batch response.Closes #3439 . Depends on #3348 merge.