Update cli to new sc-cli API #935

cecton · 2020-03-24T10:59:21Z

Forked at: 77de8b9 Parent branch: origin/master

gavofyork · 2020-03-26T11:31:30Z

please avoid making PRs where the substrate branch gets altered. use a .cargo/config to locally alter the substrate version used, and ensure that this PR is mentioned as a companion PR for the relevant substrate PR.

cecton · 2020-03-26T14:56:27Z

Hey @gavofyork o/

use a .cargo/config to locally alter the substrate version used,

It doesn't work on cumulus and I try to not have too many different processes, working on 3 repos is already confusing enough. (I also need to make another one for cumulus since it could be breaking.)

Note that this PR is in draft. I will revert the changes on Cargo.toml when the companion PR will be merged and this one will become ready to review.

ensure that this PR is mentioned as a companion PR for the relevant substrate PR.

It is (you can see it in the logs of this PR) in both directions.

Forked at: 77de8b9 Parent branch: origin/master

Commit: 5f37995 Parent branch: origin/master Forked at: 77de8b9

Commit: 710f4ca Parent branch: origin/master Forked at: 77de8b9

Commit: dd3fa1e Parent branch: origin/master Forked at: 77de8b9

Commit: c130ab1 Parent branch: origin/master Forked at: 77de8b9

Commit: 2aa46b7 Parent branch: origin/master Forked at: 77de8b9

Commit: 0a1c99f Parent branch: origin/master Forked at: 77de8b9

Commit: 238016d Parent branch: origin/master Forked at: 77de8b9

Commit: 639dfd6 Parent branch: origin/master Forked at: 77de8b9

Commit: fb358e8 Parent branch: origin/master Forked at: 77de8b9

Parent branch: origin/master Forked at: 77de8b9

build.rs

23dda62 Rococo <> Wococo messages relay (#1030) bcde21d Update the wasm builder to substrate master (#1029) a8318ce Make target signer optional when sending message. (#1018) f8602e1 Fix insufficient balance when send message. (#1020) d95c0a7 greedy relayer don't need message dispatch to be prepaid if dispatch is supposed to be paid at the target chain (#1016) ad5876f Update types. (#1027) 116cbbc CI: fix starting the pipeline (#1022) 7e0fadd Add temporary `canary` job (#1019) 6787091 Update types to contain dispatch_fee_payment (#1017) 03f79ad Allow Root to assume SourceAccount. (#1011) 372d019 Return dispatch_fee_payment from message details RPC (#1014) 604eb1c Relay basic single-bit message dispatch results back to the source chain (#935) bf52fff Use plain source_queue view when selecting nonces for delivery (#1010) fc5cf7d pay dispatch fee at target chain (#911) 1e35477 Bump Substrate to `286d7ce` (#1006) 7ad07b3 Add --only-mandatory-headers mode (#1004) 5351dc9 Messages relayer operating mode (#995) 9bc29a7 Rococo <> Wococo relayer balance guard (#998) bc17341 rename messages_dispatch_weight -> message_details (#996) 95be244 Bump Rococo and Wococo spec versions (#999) c35567b Move ChainWithBalances::NativeBalance -> Chain::Balance (#990) 1bfece1 Fix some nits (#988) 334ea0f Increase pause before starting relays again (#989) 7fb8248 Fix clippy in test code (#993) d60ae50 fix clippy issues (#991) 75ca813 Make sure GRANDPA shares state with RPC. (#987) da2a38a Bump Substrate (#986) 5a9862f Update submit finality proof weight formula (#981) 69df513 Flag for rejecting all outbound messages (#982) 14d0506 Add script to setup bench machine. (#984) e74e8ab Move CI from GitHub Actions to GitLab (#814) c5ca5dd Custom justification verification (#979) 643f10d Always run on-demand headers relay in complex relay (#975) a35b0ef Add JSON type definitions for Rococo<>Wococo bridge (#977) 0eb83f2 Update cargo.deny (#980) e1d1f4c Bump Rococo/Wococo spec_version (#976) deac90d increase pause before starting relays (#974) 68d6d79 Revert to use InspectCmd, bump substrate `6bef4f4` (#966) 66e1508 Avoid hashing headers twice in verify_justification (#973) a31844f Bump `environmental` dependency (#972) 2a4c29a in auto-relays keep trying to connect to nodes until connection is established (#971) 0e767b3 removed stray file (#969) b9545dc Serve multiple lanes with single complex relay instance (#964) 73419f4 Correct type error (#968) bac256f Start finality relay spec-version guards for Rococo <> Wococo finality relays (#965) bfd7037 pass source and target chain ids to account_ownership_proof (#963) 8436073 Upstream changes from Polkadot repo (#961) e58d851 Increase account endowment amount (#960) git-subtree-dir: bridges git-subtree-split: 23dda6248236b27f20d76cbedc30e189cc6f736c

fd24e98 send R<>W messages using relay 8386837 Rococo <> Wococo messages relays 738b756 moved dummy runtime from primitives to relay client 9a42472 copypaste storage_map_final_key to avoid different runtime references/dummy runtimes 52fdf6f impl Parameter for () 80411ba FromBridgedChainEncodedMessageCall<B> -> FromBridgedChainEncodedMessageCall<DecodedCall> 2714baf Chain::ID -> Bridge::THIS_CHAIN_ID+Bridge::BRIDGED_CHAIN_ID c6ef980 MessagesInstance -> BridgedMessagesInstance 03f79ad Allow Root to assume SourceAccount. (#1011) 372d019 Return dispatch_fee_payment from message details RPC (#1014) 604eb1c Relay basic single-bit message dispatch results back to the source chain (#935) bf52fff Use plain source_queue view when selecting nonces for delivery (#1010) fc5cf7d pay dispatch fee at target chain (#911) 1e35477 Bump Substrate to `286d7ce` (#1006) 7ad07b3 Add --only-mandatory-headers mode (#1004) 5351dc9 Messages relayer operating mode (#995) 9bc29a7 Rococo <> Wococo relayer balance guard (#998) bc17341 rename messages_dispatch_weight -> message_details (#996) 95be244 Bump Rococo and Wococo spec versions (#999) c35567b Move ChainWithBalances::NativeBalance -> Chain::Balance (#990) 1bfece1 Fix some nits (#988) 334ea0f Increase pause before starting relays again (#989) 7fb8248 Fix clippy in test code (#993) d60ae50 fix clippy issues (#991) 75ca813 Make sure GRANDPA shares state with RPC. (#987) da2a38a Bump Substrate (#986) 5a9862f Update submit finality proof weight formula (#981) 69df513 Flag for rejecting all outbound messages (#982) 14d0506 Add script to setup bench machine. (#984) e74e8ab Move CI from GitHub Actions to GitLab (#814) c5ca5dd Custom justification verification (#979) 643f10d Always run on-demand headers relay in complex relay (#975) a35b0ef Add JSON type definitions for Rococo<>Wococo bridge (#977) 0eb83f2 Update cargo.deny (#980) e1d1f4c Bump Rococo/Wococo spec_version (#976) deac90d increase pause before starting relays (#974) 68d6d79 Revert to use InspectCmd, bump substrate `6bef4f4` (#966) 66e1508 Avoid hashing headers twice in verify_justification (#973) a31844f Bump `environmental` dependency (#972) 2a4c29a in auto-relays keep trying to connect to nodes until connection is established (#971) 0e767b3 removed stray file (#969) b9545dc Serve multiple lanes with single complex relay instance (#964) 73419f4 Correct type error (#968) bac256f Start finality relay spec-version guards for Rococo <> Wococo finality relays (#965) bfd7037 pass source and target chain ids to account_ownership_proof (#963) 8436073 Upstream changes from Polkadot repo (#961) e58d851 Increase account endowment amount (#960) git-subtree-dir: bridges git-subtree-split: fd24e9849fffafa92402440db9584daab96c36f2

cecton added 5 commits March 24, 2020 09:20

Initial commit

2a2ed8e

Forked at: 77de8b9 Parent branch: origin/master

Switch substrate to branch cecton-the-revenge-of-the-cli

44ed5c6

Adapting code

1690b05

Update Cargo.lock

8ea2ad7

Adapting code

d675fe2

cecton mentioned this pull request Mar 24, 2020

CLI: refactoring: remove Options from sc_service::Configuration's fields paritytech/substrate#5271

Merged

cecton added 5 commits March 24, 2020 12:11

Adapt more code

c67277a

Implement force_kusama parameter

711d47a

Revert dependency update

6057c42

Adapt code to use ref to SubstrateCli object

1681355

Updated to latest version

1bae550

cecton added 2 commits March 26, 2020 16:13

Updated with latest changes

738d91d

Bump spec vesion

24a7a32

paritytech-ci added the B2-breaksapi label Mar 26, 2020

Fixed tests

e449dc9

gavofyork added A0-please_review Pull request needs code review. A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Mar 26, 2020

WIP

a2dbe42

Forked at: 77de8b9 Parent branch: origin/master

cecton self-assigned this Mar 26, 2020

cecton added 8 commits March 26, 2020 17:26

More fixes

5ef5fb6

Update from parent 'origin/master' (no conflict)

9d0facf

Commit: 5f37995 Parent branch: origin/master Forked at: 77de8b9

Update from parent 'origin/master' (conflicts)

2f5a915

Commit: 710f4ca Parent branch: origin/master Forked at: 77de8b9

Update from parent 'origin/master' (no conflict)

8671462

Commit: dd3fa1e Parent branch: origin/master Forked at: 77de8b9

Cargo.lock

b835d3f

Update from parent 'origin/master' (no conflict)

5d4e853

Commit: c130ab1 Parent branch: origin/master Forked at: 77de8b9

Update from parent 'origin/master' (conflicts)

56f5304

Commit: 2aa46b7 Parent branch: origin/master Forked at: 77de8b9

Updated code

e765f1a

cecton added 6 commits March 27, 2020 10:58

Fixed and adapt

2a6125f

Fixed dependency issue with wasm

6ae179d

Adapted code

f311088

Update from parent 'origin/master' (conflicts)

68deba8

Commit: 0a1c99f Parent branch: origin/master Forked at: 77de8b9

Update from parent 'origin/master' (no conflict)

8de5120

Commit: 238016d Parent branch: origin/master Forked at: 77de8b9

Revert branch change

194a9d9

cecton marked this pull request as ready for review April 1, 2020 10:11

cecton added 10 commits April 2, 2020 09:50

Update from parent 'origin/master' (no conflict)

b0c90ce

Commit: 639dfd6 Parent branch: origin/master Forked at: 77de8b9

Update from parent 'origin/master' (conflicts)

3cfaeda

Commit: fb358e8 Parent branch: origin/master Forked at: 77de8b9

Cargo.lock

39ed769

Merge commit 3a17550 (no conflict)

2ddf7f5

Parent branch: origin/master Forked at: 77de8b9

Merge commit dddf83f (conflicts)

686cbb7

Parent branch: origin/master Forked at: 77de8b9

Merge commit 587588f (no conflict)

09cb3f1

Parent branch: origin/master Forked at: 77de8b9

Merge commit 36e9d17 (conflicts)

d41d65b

Parent branch: origin/master Forked at: 77de8b9

Merge commit ed2c4ca (no conflict)

1abd782

Parent branch: origin/master Forked at: 77de8b9

Cargo.lock

6e49cf4

Adapt code

c66a094

cecton requested a review from bkchr April 7, 2020 06:38

bkchr approved these changes Apr 7, 2020

View reviewed changes

build.rs Outdated Show resolved Hide resolved

cecton added 3 commits April 7, 2020 09:25

Clean-up

f450e31

More clean-up

e3cc92d

Cargo.lock

45c0518

bkchr merged commit bee86bb into master Apr 7, 2020

bkchr deleted the cecton-the-revenge-of-the-cli branch April 7, 2020 10:08

andresilva mentioned this pull request Apr 14, 2020

add new implementation names paritytech/substrate-telemetry#251

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cli to new sc-cli API #935

Update cli to new sc-cli API #935

cecton commented Mar 24, 2020

gavofyork commented Mar 26, 2020

cecton commented Mar 26, 2020

Update cli to new sc-cli API #935

Update cli to new sc-cli API #935

Conversation

cecton commented Mar 24, 2020

gavofyork commented Mar 26, 2020

cecton commented Mar 26, 2020