Skip to content
This repository has been archived by the owner on Feb 14, 2021. It is now read-only.

Add create2 under kip4 feature flag #12

Merged
merged 2 commits into from
Aug 6, 2018
Merged

Add create2 under kip4 feature flag #12

merged 2 commits into from
Aug 6, 2018

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Aug 6, 2018

rel openethereum/parity-ethereum#9277

When feature kip4 is enabled, add the create2 function.

@sorpaas sorpaas requested review from pepyakin and NikVolf August 6, 2018 07:37
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/ext.rs Outdated
@@ -74,6 +74,9 @@ mod external {

pub fn create(endowment: *const u8, code_ptr: *const u8, code_len: u32, result_ptr: *mut u8) -> i32;

#[cfg(feature = "kip4")]
pub fn create2(endowment: *const u8, salt: *const u8, code_ptr: *const u8, code_len: u32, result_ptr: *mut u8) -> i32;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants