Release v0.11.0 #127
Merged
Release v0.11.0 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
reviewed
Aug 25, 2021
| /// A Rust primitive type. | ||
| Primitive(TypeDefPrimitive), | ||
| /// A type using the [`Compact`] encoding | ||
| Compact(TypeDefCompact<T>), | ||
| /// A type representing a sequence of bits. | ||
| BitSequence(TypeDefBitSequence<T>), | ||
| /// A Range type. | ||
| Range(TypeDefRange<T>), |
There was a problem hiding this comment.
Oh good point. Do you mind mentioning this in the docs as well?
There was a problem hiding this comment.
That it is backwards compatible, or that new variants should be added to the end?
There was a problem hiding this comment.
The latter. Something like "Tooling relying on scale-info data generally relies on order to find items. For this reason it is important that public enums add new variants items to the end to ensure backwards compatibility"?
There was a problem hiding this comment.
I've gone a step further and added explicit indices for this and TypeDefPrimitive, in case people delete or reorder variants.
dvdplm
approved these changes
Aug 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
TypeDefandTypeDefPrimitiveenums (#127)Also this moves the
Rangevariant to the end, for backwards compatibility. /cc @jacogr