Allow configuring winner count in dry-run #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
changed the title
lexnv
approved these changes
Apr 27, 2023
niklasad1
reviewed
Apr 29, 2023
niklasad1
reviewed
Apr 29, 2023
| Ok(Err(err)) => Err(Error::Other(format!("{:?}", err))), | ||
| Err(err) => Err(err.into()), | ||
| } | ||
| } | ||
|
|
||
| /// The result of calling [`fetch_snapshot_and_mine_solution`]. | ||
| pub struct MinedSolution<T: MinerConfig> { |
There was a problem hiding this comment.
nice 👍
much cleaner than what I did earlier
niklasad1
approved these changes
May 1, 2023
niklasad1
reviewed
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing winner-count into the
dry-runcommand, and make providing the account ID optional.Does anything else need adding/doing to make this useful (eg other config to allow overriding)? (I think in that case I might be tempted to have a separate
simulatecommand like the original issue suggests)Closes #461