Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands module to expose each sub-command, and put options next to them #540

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

jsdw
Copy link
Contributor

@jsdw jsdw commented Apr 27, 2023

This is a slightly opinionated reshuffle of things to:

  • Make it clear what the main entry points (subcommands) are by putting them into a commands module.
  • Put the options for each subcommand next to it (thinning out the opts module somewhat; maybe we can go fruther because not everything in that is related to CLI opts by the looks of it).
  • Remove a couple of things from prelude (just because personally I think it's easier to write but harder to read/follow where things come from when prelude::* is used for too many imports).

What do you reckon?

src/prelude.rs Outdated Show resolved Hide resolved
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
@jsdw jsdw merged commit 615b8a3 into main Apr 28, 2023
@jsdw jsdw deleted the jsdw-command-mod branch April 28, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants