Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added label filter #18
Added label filter #18
Changes from 5 commits
6c94ae1
bfa10d7
e30a037
16ba0af
50726a4
3a6b43a
8b88930
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the implementation is incorrect (or I didn't understand the described behaviour?)
Example, for the input:
The function returns
true
, even though the issue didn't have therequired2
label.Which doesn't match "Short for
Ignore issues without any of the required labels
"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation checks if one of the labels is in the issue, so that's planned.
We haven't had a request that all labels must be in the issue, so I decided to go with the easier factor (and most of the time they only request a single label).
If we get that request I would add that feature, but I believe that it would be overenginered if I apply right now.
what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, works for me, in that case can we change the text
Ignore issues without any of the required labels
intoOnly include issues with at least one of the required labels
? It caused me to misunderstand the described behaviour, I think it's more unambiguous this way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I updated the readme and added a detailed explanation on how it works