Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-staking: properly call into try_state in tests #12199

Closed
kianenigma opened this issue Sep 6, 2022 · 0 comments · Fixed by #12453
Closed

pallet-staking: properly call into try_state in tests #12199

kianenigma opened this issue Sep 6, 2022 · 0 comments · Fixed by #12453
Assignees
Labels
I5-tests Tests need fixing, improving or augmenting.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Sep 6, 2022

... instead of manually re-implementing some of the checks in mock.rs

fn post_conditions() {
check_nominators();
check_exposures();
check_ledgers();
check_count();
}

kinda related to #12130.

Ideally, in all pallets, we should call in that pallet's try-state at the end of each tests, but I am not sure if and how there is a way to enforce that, other than doing it manually, as we are doing for staking here.

@kianenigma kianenigma added the I5-tests Tests need fixing, improving or augmenting. label Sep 6, 2022
@kianenigma kianenigma moved this to 📕 Backlog in (Nominated) Proof of Stake Sep 6, 2022
@kianenigma kianenigma moved this from 📕 Backlog to ⌛️ Sometime-soon in (Nominated) Proof of Stake Sep 6, 2022
Repository owner moved this from ⌛️ Sometime-soon to ✅ Done in (Nominated) Proof of Stake Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants