Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Multi-Asset Treasury] Make the Pay trait in salary pallet generic over assets and central #13603

Closed
tonyalaribe opened this issue Mar 14, 2023 · 2 comments
Closed

[Multi-Asset Treasury] Make the Pay trait in salary pallet generic over assets and central #13603

tonyalaribe opened this issue Mar 14, 2023 · 2 comments
Assignees
@franciscoaguirre
Labels
J0-enhancement An additional feature request.

Comments

@tonyalaribe
Copy link
Contributor

tonyalaribe commented Mar 14, 2023 •
edited
Loading

Motivation

The Pay trait is a very useful trait, as the multi-asset treasury could be implemented based off said trait, instead of forcing the treasury pallet to be implmented based off either fungible or fungibles. This brings for great flexibility.

Request

Move the Pay trait out of the salary pallet (eg into frame_support), and make it generic over assets. This could be by adding an AssetId associated type or similar. The AssetId type could then be unit in the case of implementations that do not need to support multiple asset classes.

This is a step towards paritytech/polkadot-sdk#98
@tonyalaribe tonyalaribe added the J0-enhancement An additional feature request. label Mar 14, 2023
@tonyalaribe tonyalaribe mentioned this issue Mar 14, 2023
Open
@franciscoaguirre
Copy link
Contributor

I can grab this

@franciscoaguirre franciscoaguirre self-assigned this Mar 15, 2023
@franciscoaguirre franciscoaguirre mentioned this issue Mar 15, 2023
Merged
@wischli
Copy link
Contributor

wischli commented Mar 27, 2023

Can this be closed as #13609 has been merged?

@ggwpez ggwpez closed this as completed Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@franciscoaguirre franciscoaguirre

Labels
J0-enhancement An additional feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@franciscoaguirre @tonyalaribe @ggwpez @wischli