Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime-cli integration tests #13793

Closed
2 tasks done
liamaharon opened this issue Mar 31, 2023 · 1 comment
Closed
2 tasks done

try-runtime-cli integration tests #13793

liamaharon opened this issue Mar 31, 2023 · 1 comment
Labels
I5-tests Tests need fixing, improving or augmenting. J0-enhancement An additional feature request.

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Mar 31, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

try-runtime has generally low test coverage. follow-chain recently broke for a while without anyone noticing, and there're a few unresolved try-runtime related issues.

Request

(Rephrasing @kianenigma) An integration test to make sure the payload that is built in various try-runtime-cli commands matches the trait def (expected payload). We could: move trait TryRuntime to sp-try-runtime (or keep it where it is). Provide a fake implementation of it, and call into that fake implementation with the payload. Or, a realistic test that actually builds a wasm from substrate-node-template, but I don't know how to do that exactly.

Solution

No response

Are you willing to help with this request?

Yes!

@liamaharon liamaharon added I5-tests Tests need fixing, improving or augmenting. J0-enhancement An additional feature request. labels Mar 31, 2023
@liamaharon
Copy link
Contributor Author

duplicate of #13796

@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting. J0-enhancement An additional feature request.
Projects
Status: Done
Development

No branches or pull requests

1 participant