Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improvements for verifier fork-choice & import-queue #3623

Open
rphmeier opened this issue Sep 16, 2019 · 0 comments
Open

Improvements for verifier fork-choice & import-queue #3623

rphmeier opened this issue Sep 16, 2019 · 0 comments
Labels
I7-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

Verifiers, being inherently parallelizable, should not be making decisions about fork-choice, since they don't have up-to-date information about the best block and any fork-choice that they make could be pre-empted by another import.

Two items:

  • The verifier shouldn't have the option to return a fork-choice in BlockImportParams. fork-choice determination be done completely within the BlockImport structure, because it does sequential import of blocks.
  • It would be nice for the verifier to return data that is passed through the pipeline to the block import down the line. Some investigation is needed to see how this can be done with minimal impact on BlockImport composability.
@rphmeier rphmeier added the I7-refactor Code needs refactoring. label Sep 16, 2019
@rphmeier rphmeier changed the title Improvements for verifier fork-choice applications Improvements for verifier fork-choice & import-queue Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

1 participant