Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow registering custom request-response protocols #5536

Closed
Tracked by #989
tomaka opened this issue Apr 6, 2020 · 8 comments · Fixed by #6634
Closed
Tracked by #989

Allow registering custom request-response protocols #5536

tomaka opened this issue Apr 6, 2020 · 8 comments · Fixed by #6634
Assignees
Labels
J0-enhancement An additional feature request.

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 6, 2020

Just like one can register notifications protocols, one should be able to register targeted request-response protocols.

I'm opening this issue to keep track of that feature.

cc'ing @mxinden @rphmeier as we discussed this in a meeting a couple of weeks ago (when the world was not on lockdown)

@tomaka
Copy link
Contributor Author

tomaka commented Apr 16, 2020

For what it's worth, this issue is low-priority to me, but if there's an urgent need I can probably open a properly-tested PR in a day or two.

@rphmeier
Copy link
Contributor

We haven't had issues so far emulating request/response over notifications-based protocols, so I also don't view this as high-priority.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 9, 2020

Can now be done after #6559
The major obstacle to this now is to design an API.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 14, 2020

I briefly wanted to highlight that request-response protocols would show up in Grafana similar to this:

Screenshot from 2020-07-14 13-09-57

(one section like that per protocol)

Which is going to be very useful to figure out if things are working as expected.

@tomaka
Copy link
Contributor Author

tomaka commented Aug 26, 2020

In #6634, starting a request to a node we're not connected to immediately fails. However, after chatting with Rob, there is a need for a function that tries to dial the node if we happen to not be connected to it.

@ghost ghost closed this as completed in #6634 Aug 27, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Aug 27, 2020

Reopening to address this comment:

In #6634, starting a request to a node we're not connected to immediately fails. However, after chatting with Rob, there is a need for a function that tries to dial the node if we happen to not be connected to it.

@tomaka
Copy link
Contributor Author

tomaka commented Sep 7, 2020

Note-keeping: the reason for being able to perform requests to nodes we're not connected to is because we are not necessarily guaranteed a peer slot on the target node.

If, instead, there exists a system that guarantees a peer slot, then this isn't needed.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 28, 2021

Last comment addressed through #8008
Closing

@tomaka tomaka closed this as completed Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
2 participants