Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Block Fullness with Operational and Normal Dispatches #5758

Closed
shawntabrizi opened this issue Apr 23, 2020 · 0 comments · Fixed by #5954
Closed

Block Fullness with Operational and Normal Dispatches #5758

shawntabrizi opened this issue Apr 23, 2020 · 0 comments · Fixed by #5954
Labels
J0-enhancement An additional feature request.

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented Apr 23, 2020

In Substrate, we allow normal dispatches to only use up to a certain percent of a block's maximum weight. An operational dispatch on the other hand can use the full block weight.

As implemented currently, the following "equal" scenarios will not have the same result:

Max Block Weight: 1000, Available Block Ratio 75%

Scenario 1:

  • Add normal dispatch with weight 750
  • Add operational dispatch with weight 250
  • Successful block is built with both dispatches

Scenario 2:

  • Add operational dispatch with weight 250
  • Add normal dispatch with weight 750
  • Normal dispatch is rejected because it would push the block weight over 750.

This would be pretty simply solved by separating the tracking of operational and normal dispatches, but would ultimately alter the existing logic for Substrate.

This issue is to call out this issue, to agree on what behavior we want, and to make our documentation explicit about that behavior.

cc @thiolliere @kianenigma

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants