Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Asyncify keystore #5931

Closed
rakanalh opened this issue May 6, 2020 · 3 comments
Closed

Asyncify keystore #5931

rakanalh opened this issue May 6, 2020 · 3 comments
Assignees
Labels
J0-enhancement An additional feature request.

Comments

@rakanalh
Copy link
Contributor

rakanalh commented May 6, 2020

This is part of the work that has to be done in order to implement #4689.

The goal of this issue is to:

  1. convert the trait BareCryptoStore to define async functions.
  2. Rename the current Store in sc_keystore to LocalStore and update the interface accordingly.

#4689 Would then introduce RemoteStore which implements BareCryptoStore and is able to relay key management to the remote signer.

I am separating both issues so that i can merge smaller, easier to merge PRs and to prevent the scope of the parent issue from getting bigger.

@rakanalh rakanalh added J0-enhancement An additional feature request. M4-core labels May 6, 2020
@rakanalh rakanalh self-assigned this May 6, 2020
@burdges
Copy link

burdges commented May 6, 2020

How is the keystore structured now? It already does the signing itself?

@rakanalh
Copy link
Contributor Author

rakanalh commented May 7, 2020

The keystore currently lives in it's own crate here: https://github.com/paritytech/substrate/blob/master/client/keystore/

And through #4925, we made signing go through the keystore instead of using the pairs directly to enable the introduction of a remote keystore.

@rakanalh
Copy link
Contributor Author

rakanalh commented Nov 4, 2020

This was done in #7000

@rakanalh rakanalh closed this as completed Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants