Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove light-client specific GRANDPA block import #6893

Closed
andresilva opened this issue Aug 14, 2020 · 3 comments · Fixed by #7546
Closed

Remove light-client specific GRANDPA block import #6893

andresilva opened this issue Aug 14, 2020 · 3 comments · Fixed by #7546
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@andresilva
Copy link
Contributor

Currently we have separate instances of BlockImport for dealing with GRANDPA logic for full and light nodes. Initially the full node used to call into the runtime when importing a block (to fetch authorities IIRC). This is no longer the case and the light client can just use the regular GrandpaBlockImport (I've tested and it works). Is there any reason why we need to have separate handling for the light client and use finality proofs (instead of just regular justifications as in the full node).

cc @svyatonik

@andresilva andresilva added J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Aug 14, 2020
@andresilva
Copy link
Contributor Author

For example, in BABE we have no special handling for the light client and just use the same BabeBlockImport.

@ayushmishra2005
Copy link
Contributor

@andresilva Could you please guide me from where I can start looking into the code?

@andresilva
Copy link
Contributor Author

andresilva commented Oct 26, 2020

@ayushmishra2005 I already have these changes done in a branch, this issue was more for tracking discussion on this change. Thank you anyway! :)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants