Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change report_defunct_voter so that it doesn't pay to make bad votes. #7030

Closed
gavofyork opened this issue Sep 4, 2020 · 0 comments · Fixed by #7040
Closed

Change report_defunct_voter so that it doesn't pay to make bad votes. #7030

gavofyork opened this issue Sep 4, 2020 · 0 comments · Fixed by #7040
Assignees
Labels
I7-refactor Code needs refactoring.

Comments

@gavofyork
Copy link
Member

In order to ensure that Governance proxies cannot drain accounts, it's important to avoid any governance operations which can result in funds being reserved and slashed and that the weight system is used to charge the calling account for frivolous computation.

vote should be refactored so that it reserves the "right" amount of a deposit, and report_defunct_voter should be redone so that the correct (or at least maximum) amount of weight is charged-for up front. The deposit can be returned to the original account in the success case, and no further action taken in the case of no success.

@gavofyork gavofyork added the I7-refactor Code needs refactoring. label Sep 4, 2020
@kianenigma kianenigma self-assigned this Sep 7, 2020
@ghost ghost closed this as completed in #7040 Jan 20, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants