Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

There are some warnings in wasm tests with a newest CI image. #7397

Closed
TriplEight opened this issue Oct 26, 2020 · 0 comments
Closed

There are some warnings in wasm tests with a newest CI image. #7397

TriplEight opened this issue Oct 26, 2020 · 0 comments

Comments

@TriplEight
Copy link
Contributor

Yes, it works with the latest image. However, there are some warnings in wasm tests:

   Compiling substrate-prometheus-endpoint v0.8.0 (/builds/utils/prometheus)
warning: unused imports: `FutureExt`, `future::Future`
  --> utils/prometheus/src/lib.rs:17:20
   |
17 | use futures_util::{FutureExt, future::Future};
   |                    ^^^^^^^^^  ^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `Encoder`, `TextEncoder`
  --> utils/prometheus/src/lib.rs:29:18
   |
29 | use prometheus::{Encoder, TextEncoder, core::Collector};
   |                  ^^^^^^^  ^^^^^^^^^^^

warning: 2 warnings emitted
   Compiling rand_chacha v0.2.2
warning: unused imports: `FutureExt`, `future::Future`
  --> utils/prometheus/src/lib.rs:17:20
   |
17 | use futures_util::{FutureExt, future::Future};
   |                    ^^^^^^^^^  ^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `Encoder`, `TextEncoder`
  --> utils/prometheus/src/lib.rs:29:18
   |
29 | use prometheus::{Encoder, TextEncoder, core::Collector};
   |                  ^^^^^^^  ^^^^^^^^^^^

warning: 2 warnings emitted
warning: unused import: `std::io`
  --> client/rpc-servers/src/lib.rs:25:5
   |
25 | use std::io;
   |     ^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `log::error`
  --> client/rpc-servers/src/lib.rs:27:5
   |
27 | use log::error;
   |     ^^^^^^^^^^

warning: constant is never used: `MAX_PAYLOAD`
  --> client/rpc-servers/src/lib.rs:31:1
   |
31 | const MAX_PAYLOAD: usize = 15 * 1024 * 1024;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: constant is never used: `WS_MAX_CONNECTIONS`
  --> client/rpc-servers/src/lib.rs:34:1
   |
34 | const WS_MAX_CONNECTIONS: usize = 100;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: 4 warnings emitted
warning: unused import: `FrozenForDuration`
  --> client/db/src/light.rs:44:31
   |
44 | use crate::{DatabaseSettings, FrozenForDuration, DbHash};
   |                               ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: 1 warning emitted
   Compiling pallet-staking v2.0.0 (/builds/frame/staking)
warning: unused variable: `enable_mdns`
   --> client/network/src/discovery.rs:169:4
    |
169 |             enable_mdns,
    |             ^^^^^^^^^^^ help: try ignoring the field: `enable_mdns: _`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: 1 warning emitted
   Compiling sc-service v0.8.0 (/builds/client/service)
warning: unused import: `io`
  --> client/service/src/config.rs:27:11
   |
27 | use std::{io, future::Future, path::{PathBuf, Path}, pin::Pin, net::SocketAddr, sync::Arc};
   |           ^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `io`
  --> client/service/src/lib.rs:37:11
   |
37 | use std::{io, pin::Pin};
   |           ^^

warning: unused import: `std::net::SocketAddr`
  --> client/service/src/lib.rs:38:5
   |
38 | use std::net::SocketAddr;
   |     ^^^^^^^^^^^^^^^^^^^^

warning: unused import: `parity_util_mem::MallocSizeOf`
  --> client/service/src/lib.rs:50:5
   |
50 | use parity_util_mem::MallocSizeOf;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: missing documentation for a trait
  --> client/service/src/lib.rs:91:1
   |
91 | pub trait MallocSizeOfWasm {}
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> client/service/src/lib.rs:22:9
   |
22 | #![warn(missing_docs)]
   |         ^^^^^^^^^^^^

warning: 5 warnings emitted
   Compiling node-rpc v2.0.0 (/builds/bin/node/rpc)
warning: type alias is never used: `FullClient`
  --> bin/node/cli/src/service.rs:39:1
   |
39 | type FullClient = sc_service::TFullClient<Block, RuntimeApi, Executor>;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: type alias is never used: `FullBackend`
  --> bin/node/cli/src/service.rs:40:1
   |
40 | type FullBackend = sc_service::TFullBackend<Block>;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: type alias is never used: `FullSelectChain`
  --> bin/node/cli/src/service.rs:41:1
   |
41 | type FullSelectChain = sc_consensus::LongestChain<FullBackend, Block>;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: type alias is never used: `FullGrandpaBlockImport`
  --> bin/node/cli/src/service.rs:42:1
   |
42 | / type FullGrandpaBlockImport =
43 | |     grandpa::GrandpaBlockImport<FullBackend, Block, FullClient, FullSelectChain>;
   | |_________________________________________________________________________________^

warning: function is never used: `new_partial`
  --> bin/node/cli/src/service.rs:46:8
   |
46 | pub fn new_partial(config: &Configuration) -> Result<sc_service::PartialComponents<
   |        ^^^^^^^^^^^

warning: struct is never constructed: `NewFullBase`
   --> bin/node/cli/src/service.rs:161:12
    |
161 | pub struct NewFullBase {
    |            ^^^^^^^^^^^

warning: function is never used: `new_full_base`
   --> bin/node/cli/src/service.rs:171:8
    |
171 | pub fn new_full_base(
    |        ^^^^^^^^^^^^^

warning: function is never used: `new_full`
   --> bin/node/cli/src/service.rs:338:8
    |
338 | pub fn new_full(config: Configuration)
    |        ^^^^^^^^

warning: function is never used: `new_light`
   --> bin/node/cli/src/service.rs:443:8
    |
443 | pub fn new_light(config: Configuration) -> Result<TaskManager, ServiceError> {
    |        ^^^^^^^^^

warning: 9 warnings emitted

Originally posted by @TriplEight in #7395 (comment)

@bkchr bkchr closed this as completed Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants