This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
CLI: refactoring: remove Options from sc_service::Configuration's fields #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because they are the same thing
cecton
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Mar 17, 2020
It looks like @cecton signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
This reverts commit 0574d06.
cecton
force-pushed
the
cecton-the-revenge-of-the-cli
branch
from
April 6, 2020 17:36
4fa9e4a
to
993b86c
Compare
bkchr
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
VersionInfo
and replace by a trait SubstrateCli that needs to be implemented on the top level structopt of the binaryspec_factory
to put on a spec factory/load spec function to help the impl of SubstrateCli (will automatically fill version, executable name, etc... for you)sc_service::Configuration
's fields where it doesn't make any sense.CliConfiguration
that needs to be implemented on structopts that are considered as commands (subcommands and runcmd). This these impl are all provided by sc_cli by default but if the user add a subcommand, they will need to implement it.substrate_cli_params
to help impl the CliConfigurationimpl_version
by full version and droppedConfiguration.full_version()
Minor changes
NoExtension
andTracingReceiver
insc_service
Help needed
Please check and propose fixes for all the new documentation.
Closes #4776
polkadot companion: paritytech/polkadot#935