This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Better logging for notifications #5500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Apr 2, 2020
mxinden
reviewed
Apr 2, 2020
| log::warn!( | ||
| target: "sub-libp2p", | ||
| "📞 Failed to push message to queue, dropped it" | ||
| "📞 Queue of notifications with {} is full, dropped message (protocol: {:?})", |
There was a problem hiding this comment.
Suggested change
| "📞 Queue of notifications with {} is full, dropped message (protocol: {:?})", | |
| "📞 Notification queue with peer {} is full, dropped message (protocol: {:?})", |
This sounds better to me. Not a native speaker though.
|
I reverted the queue size change back to 256 and addressed review. |
tomaka
changed the title
|
I'm closing this one and opening #5512 instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5481
Two changes:
- Increases the size of the buffer of pending messages to 1024 as a temporary fix while sc_network::NetworkService::write_notifications should have proper back-pressure #5481 is properly tackled.EDIT: revertedThe first change should obviously go in.
The second one is more a proposal, and I'd be ok if people are against doing this.