Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically derive default mortality from System::Constants::BlockHashCount #206

Closed
Tracked by #345 ...
emostov opened this issue Dec 16, 2020 · 3 comments
Closed
Tracked by #345 ...

Comments

@emostov
Copy link
Contributor

emostov commented Dec 16, 2020

BlockHashCount is defined by the runtime and thus we cannot know for sure what an ok mortal_period is. Ideally we could fetch the BlockHashCount from the runtime and do something like find the next greatest power of two and use that as the default mortal_period

Originally posted by @niklasad1 in #204 (comment)

@emostov emostov changed the title Dynamically derive default mortality from Cystem::Constants::BlockHashCounts Dynamically derive default mortality from System::Constants::BlockHashCount Dec 16, 2020
@dvdplm
Copy link
Contributor

dvdplm commented Dec 2, 2021

Possibly related to #331. At the very least we should make it possible to specify the mortality.

@jsdw
Copy link
Collaborator

jsdw commented May 24, 2022

We can now specify the mortality. transactions default to immortal if you don't provide any params.

I could see an argument for transacitons defaulting to being mortal though, since it's a much safer default, so I guess this is still worth looking into!

@jsdw
Copy link
Collaborator

jsdw commented Apr 6, 2023

Since not all extrinsics have a mortality (it's an additional property that can vary by chain (and users can configure Subxt to have whatever additional things they want), I'm thinking to close this at this point. Users can specify Mortality at least using a slightly nice API when talking to Polkadot nodes :)

@jsdw jsdw closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants