-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin PR CI tests against specific substrate; daily compat tests against latest master. #334
Comments
I think it would be reasonable to create an issue by the workflow/cronjob if the job failed such as |
Yup, I agree; I love it! |
The CI is in place to do this now; we just need to pick a substrate binary to pin to. The difficulty is that there aren't readily available binaries to point at at the mo, so nightly and PR runs both use latest substrate. |
I'm going to close this for now; we have a nightly run against latest substrate to pick up compatibility breaks, and while it would be nice to pin PR runs to a "known" substrate so that we can choose when to upgrade, I think we can live with it how it is a bit and open an ew issue for that if we decide we want it. |
Following #329, we could also pin the integration tests carried out in CI to a specific version of substrate, so that breaking changes in substrate don't start breaking out PRs here.
We still want to know about such breaking changes, and for this we can add a new CI file that does scheduled daily runs like:
There would be a lot of code duplication if we copied all of the CI steps over (you can import jobs I think from other files), but it is probably sufficient just to run a daily
cargo test
against latest substrate.I'm not yet sure how a cron job failure here would be reported to us; I assume as a red tick on master. We'd need to make sure it was fairly obvious and easy to receive notifications for.
The text was updated successfully, but these errors were encountered: