Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: use polkadot-sdk umbrella crate #1786
deps: use polkadot-sdk umbrella crate #1786
Changes from 13 commits
2172c6c
94338b9
2669f69
0a09a43
b7eb1cb
f15b50c
e44ee9a
e7f1fbf
5226318
ec28c34
18e56f6
806e64b
c6af27f
a6b8546
52b3c57
e93e2ee
4dc3572
bfdfab9
4e3e1a2
3f340ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sp-core wasn't std before and sp-runtime was I think.. I guess std is needed here for it to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sp-runtime was already std, https://github.com/paritytech/subxt/blob/master/Cargo.toml#L143
That's why it's required to be std but yeah it could brings in more dependencies because sp-core/std wasn't enabled before...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how many more deps it ends up bringing in; maybe worth checking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should only affect
--feature --substrate-compat
and not the std or no-std which I'm okay with...Sure, lemme check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo check -p subxt-core --features substrate-compat
this branch brings 351 deps vs 350 on master, I think it's fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's all good then!