Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM shortcuts implementation #31

Closed
parro-it opened this issue Jun 27, 2017 · 1 comment
Closed

DOM shortcuts implementation #31

parro-it opened this issue Jun 27, 2017 · 1 comment
Assignees

Comments

@parro-it
Copy link
Owner

I started to implement a DOM based version of electron-localshortcut, in an effort to make it less error prone and less "aggressive".

Many issues of this module was caused by the fact that it uses globalShortcut method to register shortcuts. These interferes with the other system shortcuts, often in an obstrusive way...

The new version will instead listen for DOM keydown and keyup events, and will trigger shortcut handlers if emitted DOM events match the registered Accelerator.

Today I published keyboardevent-from-electron-accelerator, a module that take an Accelerator and convert it to a derived Keyboard event.

The new version of electron-localshortcut will use it to check if an emitted keyvoard event match a registered shortcuts.

It would be beautiful if anyone interested would check the module on runkit to help catch bugs before use the module as dependency here.

@ewnd9
Copy link

ewnd9 commented Jul 24, 2017

Related issue in Electron repo and suggested implementation electron/electron#1334 (comment)


It would be beautiful if anyone interested would check the module on runkit to help catch bugs before use the module as dependency here.

I've added an issue about "super" key since I use it the most parro-it/keyboardevent-from-electron-accelerator#5

Is there any other way to help beside manually checking everything from the regex? 😅

@parro-it parro-it self-assigned this Jul 24, 2017
@parro-it parro-it closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants