Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Cloud beforeConnect and beforeSubscribe errors should throw in ParseQuery.subscribe #1489

Closed
3 tasks done
dblythy opened this issue Jun 5, 2022 · 3 comments · Fixed by #1490
Closed
3 tasks done

Parse Cloud beforeConnect and beforeSubscribe errors should throw in ParseQuery.subscribe #1489

dblythy opened this issue Jun 5, 2022 · 3 comments · Fixed by #1490
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message type:feature New feature or improvement of existing feature

Comments

@dblythy
Copy link
Member

dblythy commented Jun 5, 2022 •
edited
Loading

New Feature / Enhancement Checklist

Current Limitation

To listen to a Parse Cloud beforeSubscribe error, you have to create an error.on listener. The error for beforeConnect and beforeSubscribe should trigger on query.subscribe

https://github.com/parse-community/parse-server/blob/443a5099059538d379fe491793a5871fcbb4f377/spec/ParseLiveQuery.spec.js#L594

Feature / Enhancement Description

Throw on await query.subscribe()

Example Use Case

Alternatives / Workarounds

Leave as is

3rd Party References
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 5, 2022 •
edited
Loading

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@dblythy dblythy mentioned this issue Jun 5, 2022
Merged
3 tasks
@mtrezza
Copy link
Member

mtrezza commented Jun 5, 2022

Is this a feature or a fix? And would changing this be a breaking change?

@mtrezza mtrezza changed the title Parse Cloud beforeConnect and beforeSubscribe errors should throw in query.subscribe Parse Cloud beforeConnect and beforeSubscribe errors should throw in ParseQuery.subscribe Jun 5, 2022
@mtrezza mtrezza changed the title Parse Cloud beforeConnect and beforeSubscribe errors should throw in ParseQuery.subscribe Parse Cloud beforeConnect and beforeSubscribe errors should throw in ParseQuery.subscribe Jun 5, 2022
@dblythy
Copy link
Member Author

dblythy commented Jun 5, 2022 •
edited
Loading

I guess it’s a feature (although it’s expected behaviour) and breaking because any query.subscribe that throws using beforeConnect/beforeSubscribe will throw

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Jun 5, 2022
@mtrezza mtrezza added state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message block:beta Needs to be resolved before next release on beta branch; remove label afterwards labels Nov 10, 2022
@mtrezza mtrezza removed the block:beta Needs to be resolved before next release on beta branch; remove label afterwards label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
2 participants
@dblythy @mtrezza