Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Schema.addField does not correctly add value of type Date #1544

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 14, 2022

New Pull Request Checklist

Issue Description

Schema.addField with type of date does not correctly convert date to iso object.

Related issue: #1545

Approach

Fixes addField for date type

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: Schema.addField does not correctly add Date fix: schema.addField does not correctly add Date Sep 14, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 14, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy
Copy link
Member Author

dblythy commented Sep 14, 2022

This is the failing test that demonstrates the issue:

it('can add date field with default value', () => {
    const schema = new ParseSchema('NewSchemaTest');
    const date = new Date();
    schema.addDate('testField', { defaultValue: date });
    schema.addField('testField2', 'Date', { defaultValue: date });
    expect(schema._fields.testField.defaultValue).toEqual({ __type: 'Date', iso: date });
    expect(schema._fields.testField2.defaultValue).toEqual({ __type: 'Date', iso: date }); // Before this PR, this is just `date.toISOString()`
  });

@dblythy dblythy requested a review from a team September 14, 2022 11:09
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 99.94% // Head: 99.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (25aab0b) compared to base (473949d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 25aab0b differs from pull request most recent head 9d7fd55. Consider uploading reports for the commit 9d7fd55 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    parse-community/parse-server#1544   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5954     5955    +1     
  Branches     1359     1360    +1     
=======================================
+ Hits         5951     5952    +1     
  Misses          3        3           
Impacted Files Coverage Δ
src/ParseSchema.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: schema.addField does not correctly add Date fix: Schema.addField does not correctly add value of type Date Sep 14, 2022
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready for merge?

@dblythy
Copy link
Member Author

dblythy commented Sep 14, 2022

Yep!

@mtrezza mtrezza linked an issue Sep 14, 2022 that may be closed by this pull request
4 tasks
@mtrezza mtrezza merged commit 15111f7 into parse-community:alpha Sep 14, 2022
@mtrezza mtrezza removed the request for review from a team September 14, 2022 12:13
@dblythy dblythy deleted the fix-schema branch September 14, 2022 12:13
parseplatformorg pushed a commit that referenced this pull request Sep 14, 2022
# [3.5.0-alpha.3](3.5.0-alpha.2...3.5.0-alpha.3) (2022-09-14)

### Bug Fixes

* `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 14, 2022
parseplatformorg pushed a commit that referenced this pull request Oct 25, 2022
# [3.5.0-beta.1](3.4.4...3.5.0-beta.1) (2022-10-25)

### Bug Fixes

* `Parse.User.signUp()` does not pass context to Cloud Code  ([#1527](#1527)) ([53edcfd](53edcfd))
* `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7))
* creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862))
* initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e))
* remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d))

### Features

* add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec))
* add json option to query.each ([299fb0d](299fb0d))
* generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5))
* localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 25, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 1, 2022
# [3.5.0](3.4.4...3.5.0) (2022-11-01)

### Bug Fixes

* `Parse.User.signUp()` does not pass context to Cloud Code  ([#1527](#1527)) ([53edcfd](53edcfd))
* `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7))
* creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862))
* initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e))
* remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d))

### Features

* add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec))
* add json option to query.each ([299fb0d](299fb0d))
* generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5))
* localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
mtrezza pushed a commit that referenced this pull request Nov 3, 2022
* `Parse.User.signUp()` does not pass context to Cloud Code  ([#1527](#1527)) ([53edcfd](53edcfd))
* `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7))
* creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862))
* initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e))
* remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d))

* add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec))
* add json option to query.each ([299fb0d](299fb0d))
* generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5))
* localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddField with type date and default value not working
3 participants