-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Schema.addField
does not correctly add value of type Date
#1544
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
This is the failing test that demonstrates the issue: it('can add date field with default value', () => {
const schema = new ParseSchema('NewSchemaTest');
const date = new Date();
schema.addDate('testField', { defaultValue: date });
schema.addField('testField2', 'Date', { defaultValue: date });
expect(schema._fields.testField.defaultValue).toEqual({ __type: 'Date', iso: date });
expect(schema._fields.testField2.defaultValue).toEqual({ __type: 'Date', iso: date }); // Before this PR, this is just `date.toISOString()`
}); |
Codecov ReportBase: 99.94% // Head: 99.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha parse-community/parse-server#1544 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 61 61
Lines 5954 5955 +1
Branches 1359 1360 +1
=======================================
+ Hits 5951 5952 +1
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Schema.addField
does not correctly add value of type Date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ready for merge?
Yep! |
# [3.5.0-alpha.3](3.5.0-alpha.2...3.5.0-alpha.3) (2022-09-14) ### Bug Fixes * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7))
🎉 This change has been released in version 3.5.0-alpha.3 |
# [3.5.0-beta.1](3.4.4...3.5.0-beta.1) (2022-10-25) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
🎉 This change has been released in version 3.5.0-beta.1 |
# [3.5.0](3.4.4...3.5.0) (2022-11-01) ### Bug Fixes * `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) ### Features * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
🎉 This change has been released in version 3.5.0 |
* `Parse.User.signUp()` does not pass context to Cloud Code ([#1527](#1527)) ([53edcfd](53edcfd)) * `Schema.addField` does not correctly add value of type `Date` ([#1544](#1544)) ([15111f7](15111f7)) * creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862)) * initialization fails in non-browser environment that doesn't support `indexedDB` ([#1569](#1569)) ([3560a5e](3560a5e)) * remove base64 validation due to validation inefficiency ([#1543](#1543)) ([473949d](473949d)) * add `json` option to `Parse.Query.each()` ([#1539](#1539)) ([89fd5ec](89fd5ec)) * add json option to query.each ([299fb0d](299fb0d)) * generate `Parse.Object.objectId` automatically when `allowCustomObjectId` is enabled and no `objectId` is passed ([#1540](#1540)) ([68f3ff5](68f3ff5)) * localDatastore support for unsorted distance queries ([#1570](#1570)) ([ea3e75f](ea3e75f))
New Pull Request Checklist
Issue Description
Schema.addField
with type of date does not correctly convert date to iso object.Related issue: #1545
Approach
Fixes
addField
for date typeTODOs before merging