Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Node 16 and 18 support #1598

Merged
merged 21 commits into from
Dec 21, 2022
Merged

feat: Add Node 16 and 18 support #1598

merged 21 commits into from
Dec 21, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 6, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

Node 16 and 18 should be in the CI

Related issue: #1597
Closes: #1597

Approach

Adds node 16 and 18

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: add Node 16, 18 ci: Add Node 16, 18 Nov 6, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 6, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy dblythy requested a review from a team November 6, 2022 05:32
@codecov
Copy link

codecov bot commented Nov 6, 2022 •
edited
Loading

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (21f6e30) compared to base (6125419).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #1598   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5973     5973           
  Branches     1367     1367           
=======================================
  Hits         5967     5967           
  Misses          6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy closed this Nov 6, 2022
@dblythy dblythy reopened this Nov 6, 2022
@mtrezza mtrezza changed the title ci: Add Node 16, 18 ci: Add Node 16 and 18 support Nov 6, 2022
mtrezza
mtrezza approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title ci: Add Node 16 and 18 support feat: Add Node 16 and 18 support Nov 6, 2022
mtrezza
mtrezza requested changes Nov 6, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you add Node 16 and 18 to the node tag in README?

image

  • Could you add Node 12 and 15 to the CI? We're currently indicating that the SDK is compatible with those.

We have #1535 where we'll drop Node 12 and 15 support and add the engines block to package.json.

@dblythy
Copy link
Member Author

dblythy commented Nov 8, 2022

npm run integration seems to be a bit flaky on Node 18

@dblythy dblythy mentioned this pull request Nov 8, 2022
Closed
4 tasks
@dblythy dblythy requested a review from mtrezza November 8, 2022 12:20
dplewis
dplewis suggested changes Nov 9, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza reviewed Nov 10, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mtrezza
Copy link
Member

mtrezza commented Nov 10, 2022 •
edited
Loading

build step is still required in repo settings, we'll remove after this PR

matrix.node-version is used in the parse-server CI want to change it?

yes, would be good to use the same nomenclature across repos

@mtrezza
Copy link
Member

mtrezza commented Nov 10, 2022 •
edited
Loading

Note 18 tests are failing randomly, could someone look into this?

@mtrezza
Copy link
Member

mtrezza commented Nov 11, 2022 •
edited
Loading

In Parse Server adding Node 18 support required to set the DNS resolution order, because it first tries to resolve for IPv6. So instead of changing localhost to an IPv4 127.0.0.1, we set this in helper.js:

// Ensure localhost resolves to ipv4 address first on node v17+
if (dns.setDefaultResultOrder) {
  dns.setDefaultResultOrder('ipv4first');
}

This has the benefit that localhost can still be used and reviewers don't need to keep that in mind when reviewing PRs in the future.

@dblythy dblythy requested review from mtrezza and dplewis November 16, 2022 13:15
mtrezza
mtrezza approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza
Copy link
Member

mtrezza commented Nov 27, 2022

Rerunning the failed tests; then this should be ready for merge, right?

@mtrezza
Copy link
Member

mtrezza commented Dec 21, 2022

Rerunning CI

@mtrezza mtrezza merged commit 2c79a31 into parse-community:alpha Dec 21, 2022
parseplatformorg pushed a commit that referenced this pull request Dec 21, 2022
@semantic-release-bot
chore(release): 4.0.0-alpha.4 [skip ci]
f714763 
# [4.0.0-alpha.4](4.0.0-alpha.3...4.0.0-alpha.4) (2022-12-21)

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 21, 2022
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
@semantic-release-bot @mtrezza
chore(release): 4.0.0-alpha.4 [skip ci]
031a522 
# [4.0.0-alpha.4](parse-community/Parse-SDK-JS@4.0.0-alpha.3...4.0.0-alpha.4) (2022-12-21)

### Features

* Add Node 16 and 18 support ([parse-community#1598](parse-community#1598)) ([2c79a31](parse-community@2c79a31))
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
@semantic-release-bot
chore(release): 4.0.0-beta.1 [skip ci]
81607f6 
# [4.0.0-beta.1](3.5.1...4.0.0-beta.1) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
5f62bbb 
# [4.0.0](3.5.1...4.0.0) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@dplewis dplewis Awaiting requested review from dplewis

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Node 16 and 18 support
4 participants
@dblythy @mtrezza @dplewis @parseplatformorg