unsaved children does not work for unsaved Parse.File

[swittk]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest versions of Parse Server and the Parse JS SDK.

Issue Description

When saving a new Parse.Object that is saved with a new Parse.File, the following error occurs.

TypeError: object._getId is not a function. (In 'object._getId()', 'object._getId' is undefined)

Likely it's from _getId() not being implemented for the ParseFile class? Since _getId() is called here when saving unsaved children.

Parse-SDK-JS/src/unsavedChildren.js

Line 37 in 8115e95

const identifier = obj.className + ':' + obj._getId();

Steps to reproduce

// a File object
const file : File;
const parseFile = new Parse.File('myFileName',  file);
const parseObject = new Parse.Object({ prop1: "hello", file: parseFile });
parseObject.save();

Actual Outcome

TypeError: object._getId is not a function. (In 'object._getId()', 'object._getId' is undefined)

Expected Outcome

No errors

Environment

Node.js v16.13.1

Server

• Parse Server version: ^5.4.0
• Operating system: Mac OS Monterey 12.5.1, Ubuntu 22.04
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local network served Node.JS

Database

• System (MongoDB or Postgres): MongoDB
• Database version: 6.0.2
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): Local network served

Client

• Parse JS SDK version: 3.5.1

Logs

TypeError: object._getId is not a function. (In 'object._getId()', 'object._getId' is undefined)

[parse-github-assistant]

Thanks for opening this issue!

• 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

[swittk]

I've pinpointed the source of the crash to this line of code

Parse-SDK-JS/src/LocalDatastore.js

Line 382 in f4bfbd2

const objectId = object.objectId || object._getId();

Would it be possible if we just added a check for Parse.File here?

[swittk]

The call appears to be localDatastore._updateLocalIdForObject (which is here). And the call is from ParseObject's save method (specifically here)

I've found that adding a check for if(object instanceof ParseObject) covering these two lines solves the issue

Parse-SDK-JS/src/ParseObject.js

Lines 2495 to 2496 in f4bfbd2

	await localDatastore._updateLocalIdForObject(mapIdForPin[object.id], object);
	await localDatastore._updateObjectIfPinned(object);

Should I open a pull request?