Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Node 22 #2209

Merged
merged 9 commits into from
Jul 7, 2024
Merged

feat: Add support for Node 22 #2209

merged 9 commits into from
Jul 7, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 7, 2024 •
edited
Loading

Pull Request

Issue

This commit aligns the repository with the currently supported Node.js versions.
See:
https://github.com/nodejs/Release

Approach

  • Add Node 22 to CI
  • Bump Node 18 and 20 to the latest releases
  • Add Node 19 for unofficial support
  • Exclude Node 21

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jul 7, 2024 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

mtrezza
mtrezza reviewed Jul 7, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jul 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (4be5268).
Report is 101 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##             alpha     #2209    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6366   +180     
  Branches      1499      1535    +36     
==========================================
+ Hits          6186      6366   +180

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtrezza
mtrezza reviewed Jul 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dplewis dplewis requested a review from a team July 7, 2024 11:28
@dplewis dplewis requested a review from mtrezza July 7, 2024 12:05
mtrezza
mtrezza requested changes Jul 7, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
mtrezza added 2 commits July 7, 2024 14:12
@mtrezza
fix node engine versions
650b932 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
add node 19
0bb7eb4
@mtrezza
Copy link
Member

mtrezza commented Jul 7, 2024

Just out of curiosity running CI with Node 19...

mtrezza
mtrezza previously approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the package-lock update; ready for merge?

mtrezza
mtrezza reviewed Jul 7, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
mtrezza
mtrezza approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit c74fd4c into parse-community:alpha Jul 7, 2024
12 checks passed
@dplewis dplewis deleted the node-22 branch July 7, 2024 12:35
parseplatformorg pushed a commit that referenced this pull request Jul 7, 2024
@semantic-release-bot
chore(release): 5.3.0-alpha.1 [skip ci]
17db8ba 
# [5.3.0-alpha.1](5.2.0...5.3.0-alpha.1) (2024-07-07)

### Features

* Add support for Node 22 ([#2209](#2209)) ([c74fd4c](c74fd4c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 7, 2024
parseplatformorg pushed a commit that referenced this pull request Jul 7, 2024
@semantic-release-bot
chore(release): 5.3.0-beta.1 [skip ci]
bc0dd72 
# [5.3.0-beta.1](5.2.0...5.3.0-beta.1) (2024-07-07)

### Bug Fixes

* `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2))

### Features

* Add support for Node 22 ([#2209](#2209)) ([c74fd4c](c74fd4c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 7, 2024
parseplatformorg pushed a commit that referenced this pull request Jul 7, 2024
@semantic-release-bot
chore(release): 5.3.0 [skip ci]
c201977 
# [5.3.0](5.2.0...5.3.0) (2024-07-07)

### Bug Fixes

* `Parse.Object.get` returns array instead of object if key name is number-like ([#2201](#2201)) ([5921ba2](5921ba2))

### Features

* Add support for Node 22 ([#2209](#2209)) ([c74fd4c](c74fd4c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 7, 2024
@parseplatformorg parseplatformorg mentioned this pull request Jul 29, 2024
Closed
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @mtrezza @parseplatformorg