feat: LiveQueryClient.close returns promise when WebSocket closes
#1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportBase: 99.90% // Head: 99.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha #1735 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 61 61
Lines 6100 6103 +3
Branches 1482 1482
=======================================
+ Hits 6094 6097 +3
Misses 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Is this a breaking change? |
|
This is not a breaking change, it’s an improvement |
mtrezza
changed the title
LiveQueryClient.close returns promise on websocket closesLiveQueryClient.close returns promise when WebSocket closes
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 6, 2023
# [4.0.0-alpha.12](4.0.0-alpha.11...4.0.0-alpha.12) (2023-02-06) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660))
|
🎉 This change has been released in version 4.0.0-alpha.12 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 1, 2023
# [4.1.0-beta.1](4.0.1...4.1.0-beta.1) (2023-03-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))
|
🎉 This change has been released in version 4.1.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 1, 2023
# [4.1.0-alpha.1](4.0.1...4.1.0-alpha.1) (2023-03-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))
|
🎉 This change has been released in version 4.1.0-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
May 1, 2023
# [4.1.0](4.0.1...4.1.0) (2023-05-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))
|
🎉 This change has been released in version 4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #1734
Approach