-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ECMAScript 6 (ES6) support #255
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master parse-community/Parse-SDK-JS#255 +/- ##
==========================================
- Coverage 91.78% 90.10% -1.68%
==========================================
Files 8 8
Lines 499 1274 +775
==========================================
+ Hits 458 1148 +690
- Misses 41 126 +85 ☔ View full report in Codecov by Sentry. |
# [6.3.0](6.2.0...6.3.0) (2024-07-07) ### Features * Add ECMAScript 6 (ES6) support ([#255](#255)) ([bee437a](bee437a))
🎉 This change has been released in version 6.3.0 |
Not sure to understand why it was switched to ESM since Parse Server is not a module and there is plenty of issues with ESM currently waiting for NodeJS in node 23-24 fix. On my side Jest is failing due to ESM in CommonJs project. Parse custom ESM detection fail for example in jest since JEST return a custom error when you try to import an ESM in Common JS. I'll fix my fork to support the jest error, a dedicated PR should be done on parse for proper ESM detection |
it seems that jest just exit if he detect ESM in commonjs, so the error detection don't work |
Are you referring to the CI tests? They seem to work. |
New Pull Request Checklist
Issue Description
The code base doesn't support async/await since babel didn't support it in the runtimegenerator. We could update babel but I don't think project needs to be trancompiled. The test suite ran against
/src
instead of/lib
so this error didn't get caughtCloses: #256
Approach
"type": "module"
topackage.json
to enable ES6C8
for test coverageTODOs before merging