Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Verbose mode is enabled if environment variables VERBOSE or VERBOSE_PARSE_SERVER_PUSH_ADAPTER are set to any value #264

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 7, 2024

New Pull Request Checklist

Issue Description

VERBOSE and VERBOSE_PARSE_SERVER_PUSH_ADAPTER usage doesn't match the documentation. The variable would have to be removed in order to turn logging off. VERBOSE=0 doesn't work since 0 is a string.

https://github.com/parse-community/parse-server-push-adapter?tab=readme-ov-file#logging

Approach

  • Check if value is 1
  • Improve code coverage

Copy link

parse-github-assistant bot commented Jul 7, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis dplewis requested review from mtrezza and a team July 7, 2024 13:07
@mtrezza mtrezza changed the title fix: VERBOSE environment variable accepting any value fix: Verbose mode is enabled if environment variables VERBOSE or VERBOSE_PARSE_SERVER_PUSH_ADAPTER are set to any value Jul 8, 2024
@mtrezza mtrezza merged commit 0f31300 into parse-community:master Jul 8, 2024
6 checks passed
parseplatformorg pushed a commit that referenced this pull request Jul 8, 2024
## [6.4.1](6.4.0...6.4.1) (2024-07-08)

### Bug Fixes

* Verbose mode is enabled if environment variables `VERBOSE` or `VERBOSE_PARSE_SERVER_PUSH_ADAPTER` are set to any value ([#264](#264)) ([0f31300](0f31300))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants