feat: Add FCM option resolveUnhandledClientError to resolve or reject push promise on FCM server response GOAWAY
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
mtrezza
changed the title
resolveUnhandledClientError to handle client error on FCM server response GOAWAY
mtrezza
changed the title
resolveUnhandledClientError to handle client error on FCM server response GOAWAYresolveUnhandledClientError to resolve or reject push promise on FCM server response GOAWAY
parseplatformorg
pushed a commit
that referenced
this pull request
Dec 14, 2024
# [6.8.0](6.7.1...6.8.0) (2024-12-14) ### Features * Add FCM option `resolveUnhandledClientError` to resolve or reject push promise on FCM server response GOAWAY ([#341](#341)) ([6d72f8a](6d72f8a))
|
🎉 This change has been released in version 6.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Closes: #340
Approach
resolveUnhandledClientErrorthat allows to customize whether client errors should be gracefully resolved (set totrue), or lead to a promise rejection for the caller to indicate that sending the push failed (set tofalse). Default isfalse.TODOs before merging