Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Server crash on FCM network error using http/2 #342

Open
4 tasks done
mtrezza opened this issue Dec 15, 2024 · 1 comment
Open
4 tasks done

Parse Server crash on FCM network error using http/2 #342

mtrezza opened this issue Dec 15, 2024 · 1 comment
Labels

Comments

@mtrezza
Copy link
Member

mtrezza commented Dec 15, 2024

New Issue Checklist

Issue Description

The http/2 implementation in firebase-admin throws on network errors instead of handling them, which lets them propagate to the node process, which eventually crashes the process.

The proper solution for any network error is to fix firebase/firebase-admin-node#2789, for example via an event listener.

Steps to reproduce

This issue occurs on network error events, such as ECONNRESET.

Actual Outcome

Unhandled error crashes app.

Expected Outcome

Error should be handled by the firebase-admin.

Workaround

  • Use the older version HTTP/1.1 by setting fcmEnableLegacyHttpTransport: true in your push options.
  • Catch the error in a global Node process error handler.

Environment

Client

  • Parse Server Push Adapter version: 6.8.0

Server

  • Parse Server version: 7.3.0
Copy link

parse-github-assistant bot commented Dec 15, 2024

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant