Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directAccess): Properly handle response status #6966

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 23, 2020

Should handle response the same way JS SDK RESTController, Single Save and Batch Save does.

  • Fix RestWrite location helper
  • Properly return status code
  • Ensure object.existed() works
  • Ensure batch endpoint returns proper response

@ghost
Copy link

ghost commented Oct 23, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #6966 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6966      +/-   ##
==========================================
- Coverage   93.83%   93.81%   -0.02%     
==========================================
  Files         169      169              
  Lines       12271    12278       +7     
==========================================
+ Hits        11514    11519       +5     
- Misses        757      759       +2     
Impacted Files Coverage Δ
src/ParseServerRESTController.js 98.38% <100.00%> (+0.20%) ⬆️
src/RestWrite.js 93.66% <100.00%> (-0.32%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.58% <0.00%> (-0.23%) ⬇️
src/vendor/mongodbUrl.js 100.00% <0.00%> (ø)
src/PromiseRouter.js 90.10% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a1b30...eb018d0. Read the comment docs.

@dplewis dplewis requested a review from davimacedo October 23, 2020 16:29
@dplewis
Copy link
Member Author

dplewis commented Oct 24, 2020

@davimacedo I edited the original post.

@dplewis dplewis requested review from TomWFox and mtrezza October 24, 2020 02:14
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dplewis dplewis merged commit e89cf25 into master Oct 25, 2020
@dplewis dplewis deleted the directaccess-status branch October 25, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants