Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move environment version check out of PR CI #7628

Closed
Moumouls opened this issue Oct 14, 2021 · 3 comments
Closed

Move environment version check out of PR CI #7628

Moumouls opened this issue Oct 14, 2021 · 3 comments
Labels
type:ci CI related issue

Comments

@Moumouls
Copy link
Member

Not a real issue, here i think that the CI Self Check is too restrictive.

A contributor will face to environment issue completely not related to his PR. I've an example on my last PRs

I think CI Self check is useful but not on a pull request event.

I suggest here to switch the CI Self Check on weekly github action to ensure that CI env is up to date as much as possible.

What do you think @mtrezza ?

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 14, 2021

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mtrezza mtrezza added the type:ci CI related issue label Oct 14, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2021

Yes, this was discussed internally when we introduced the environment check. The goal was to automatically open a PR that already bumps everything, so it only needs to be reviewed, once we have a concept for release automation. I think we are almost there now.

The CI Self Check does more than only check for environment versions, so we would not move the whole check into a separate PR but keep some parts in the CI.

For now, the contributor can just ignore the check.

@mtrezza mtrezza changed the title May be remove ci / CI Self-Check and trigger it each week independently Move environment version check our of PR CI Oct 14, 2021
@mtrezza mtrezza changed the title Move environment version check our of PR CI Move environment version check out of PR CI Oct 14, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 14, 2021

Closing via #7631, #7635; replaced the "CI Self Check" with the "Node Engine Check", splitting the environment check into a separate scheduled job.

@mtrezza mtrezza closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci CI related issue
Projects
None yet
Development

No branches or pull requests

2 participants