Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Game Center CI tests flaky #7947

Closed
4 tasks done
mtrezza opened this issue Apr 22, 2022 · 4 comments
Closed
4 tasks done

Apple Game Center CI tests flaky #7947

mtrezza opened this issue Apr 22, 2022 · 4 comments
Labels
type:ci CI related issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Apr 22, 2022

New Issue Checklist

Issue Description

CI tests related to Apple Game Center are often failing:

1) Apple Game Center Auth adapter validateAuthData should validate
2) Apple Game Center Auth adapter validateAuthData invalid signature id
  - Expected 'error:0D0680A8:asn1 encoding routines:asn1_check_tlen:wrong tag' to be 'Apple Game Center - invalid signature'.

This only started recently and the tests only fail sometimes, so it may be an issue with test structure or the random order in which the tests are executed.

Steps to reproduce

See https://github.com/parse-community/parse-server/runs/6118780493?check_suite_focus=true#step:8:3965

Actual Outcome

Tests should pass

Expected Outcome

Tests fail sometimes

Environment

n/a

Server

  • Parse Server version: [5.3.0-alpha.6](https://github.com/parse-community/parse-server/releases/tag/5.3.0-alpha.6)
@mtrezza mtrezza added the type:ci CI related issue label Apr 22, 2022
@mtrezza mtrezza pinned this issue Apr 22, 2022
@mtrezza mtrezza changed the title CI Tests CI tests related to Apple Game Center are often failing Apr 22, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 22, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza changed the title CI tests related to Apple Game Center are often failing Apple Game Center CI tests are often failing Apr 22, 2022
@mtrezza mtrezza changed the title Apple Game Center CI tests are often failing Apple Game Center CI tests flaky Apr 22, 2022
@dblythy
Copy link
Member

dblythy commented Apr 26, 2022

I believe the certificate required for gamecenter tests should be https://static.gc.apple.com/public-key/gc-prod-6.cer, as explained here

@dblythy
Copy link
Member

dblythy commented Apr 27, 2022

I think we also need to update the test signatures, however I can’t work out how to do this to get them to pass with the newer cert. @mtrezza any thoughts?

@mtrezza
Copy link
Member Author

mtrezza commented Apr 30, 2022

Closing via #7958 (comment), thanks @dblythy

@mtrezza mtrezza closed this as completed Apr 30, 2022
@mtrezza mtrezza unpinned this issue Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci CI related issue
Projects
None yet
Development

No branches or pull requests

2 participants