Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Server options should set default #8202

Open
3 tasks done
dblythy opened this issue Sep 28, 2022 · 3 comments · May be fixed by #8535
Open
3 tasks done

Parse Server options should set default #8202

dblythy opened this issue Sep 28, 2022 · 3 comments · May be fixed by #8535
Labels
type:feature New feature or improvement of existing feature

Comments

@dblythy
Copy link
Member

dblythy commented Sep 28, 2022

New Feature / Enhancement Checklist

Current Limitation

Currently, to add Parse Server options, developers have to add validation for the variable type, as well as set the default. The error messages for if a variable doesn’t enforce a type is inconsistent. And, you cannot set environment variables to deep Parse Server options. Overall, it needs some TLC.

Feature / Enhancement Description

All this information is already typed in the definitions, so the type and default should be automatically set. The only custom validation should be for stricter rules, such as checking that a parameter is greater than 0, for example.

Example Use Case

Creating a new server option would require much less code if the type handling and defaults were handled internally.

Alternatives / Workarounds

Related: #7151

3rd Party References

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 28, 2022

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Sep 28, 2022
@dblythy
Copy link
Member Author

dblythy commented Oct 12, 2022

Parse Server should also log an error when an unsupported config option is set, such as "massterKey".

@dblythy dblythy mentioned this issue Oct 12, 2022
31 tasks
@mtrezza
Copy link
Member

mtrezza commented Oct 12, 2022

I am not very fond of Parse Server's current options implementation. Our home-cooked implementation is already overly complex and has issues. Maybe we can look at that in the context of #7069 and replace it with a standardized options framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants