Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifyServerUrl does not work with new startup methods #8380

Closed
4 tasks done
Tracked by #8225
dblythy opened this issue Jan 6, 2023 · 4 comments · Fixed by #8366
Closed
4 tasks done
Tracked by #8225

verifyServerUrl does not work with new startup methods #8380

dblythy opened this issue Jan 6, 2023 · 4 comments · Fixed by #8366
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@dblythy
Copy link
Member

dblythy commented Jan 6, 2023

New Issue Checklist

Issue Description

verifyServerUrl does not respect the starting state, and can log an error when the server is starting up.

Steps to reproduce

Use new startup method, and call verifyServerUrl.

Actual Outcome

Logs "unable to connect to xxx, cloud code may not be available"

Expected Outcome

verifyServerUrl should consider startup environment

Environment

Server

  • Parse Server version: alpha
  • Operating system: macos
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): mongo
  • Database version: 5
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): atlas

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): n/a
  • SDK version: n/a

Logs

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message type:feature New feature or improvement of existing feature labels Jan 6, 2023
@mtrezza mtrezza mentioned this issue Jan 6, 2023
31 tasks
@mtrezza mtrezza added the block:major Needs to be resolved before next major release; remove label afterwards label Jan 6, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.22

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 8, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants