Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session not revoked when user password changes using Parse Dashboard #3289

Closed
anashalb opened this issue Dec 27, 2016 · 4 comments
Closed

Session not revoked when user password changes using Parse Dashboard #3289

anashalb opened this issue Dec 27, 2016 · 4 comments
Labels
type:question Support or code-level question

Comments

@anashalb
Copy link

Session is not being revoked when the user's password is changed from Parse Dashboard.

Code Ref
I noticed that the condition being checked is: if (this.query && !this.auth.isMaster), which means only non-Master authentication would allow sessions to be revoked. What about when master authentication is changing the user's password (e.g. Parse Dashboard)

Steps to reproduce

  1. Create a user in dashboard.
  2. Login the user using a rest call, which generates a session for the user.
  3. Go to dashboard and change the user's password.
  4. Observe that the Session for that user is not revoked.

Expected Results

According to the Parse Server defaults, the session is supposed to be revoked.

Actual Outcome

The session is not being revoked

Environment Setup

  • Server

    • parse-server version (Be specific! Don't say 'latest'.) : 2.2.24
    • Operating System: MacOS
    • Hardware:
    • Localhost or remote server? Localhost
  • Database

    • MongoDB version: v3.2.1
    • Storage engine: WiredTiger
    • Localhost or remote server? Localhost
@sricharan123
Copy link

same issue raised, i got the same problem. issue #3265 .

@flovilmart
Copy link
Contributor

@anashalb thanks for the info.

I'll fix this behaviour which is not intended.

  • _sessions will be clean up when password is updated
  • a new session will be created only if the user is not master

flovilmart added a commit that referenced this issue May 16, 2017
acinader pushed a commit that referenced this issue May 16, 2017
* Adds repro to  issue #3289

* Always clear sessions when password is updated
@pjbrigden
Copy link

Hey guys, do you think this issue will be resolved in the next Parse Server release? Keep up the good work!

@flovilmart
Copy link
Contributor

This has been merged and released, please re-open the issue if tis persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Support or code-level question
Projects
None yet
Development

No branches or pull requests

5 participants