Push notifications to APNS per batches #10
Conversation
Current coverage is
|
Current coverage is 88.51%@@ master #10 diff @@
==========================================
Files 5 5
Lines 261 270 +9
Methods 28 30 +2
Messages 0 0
Branches 45 46 +1
==========================================
+ Hits 230 239 +9
Misses 31 31
Partials 0 0
|
|
@drew-gross let me know what you think as it really changes the game |
|
|
||
| let promises = devices.map((device) => { | ||
| // Start by clustering the devices per connections | ||
| let devicesPerConnIndex = devices.reduce((memo, device) => { |
There was a problem hiding this comment.
I'll be honest, I don't really like this usage of reduce. reduce is from a functional paradigm, but when you modify memo inside your reduce, that feels very imperative. I'd rather see imperative code use imperative paradigms. If you wanted to copy memo with a modification, that would feel better, I think. Or just use a for loop. Or go back to map, and have the mapped function return a (connIndex, device) pair, since you just end up iterating over the (connIndex, device) pairs in arbitrary order anyway.
|
Seems fine to me but I'm not really the best person to review push related code. @bnham or @nlutsenko would probably be better. |
|
this pull request it's somewhat forgotten :) |
|
@Darkkiss thats why I ended up implementing OneSignal push adapter, not a good option tough since I use cloud code to push to thousands of installations and I don't know if parse server takes just to many seconds determining which installations should receive the push notification, so it still takes like 3-4min to push to 20k installations which is not a good option since I want to notiffy soccer matches goals and right now all of my "competence" apps are notifying faster than mine and I'm losing lots of users. If I push directly from OneSignal, the notification arrives in just a few seconds but I don't know how to tell OneSignal that I updated a record in my database other than using cloud code and the push adapter. If you find a better alternative please let me know |
|
@flovilmart it's there any change for some hints about this adapter ... I would like to do it .. but don't know exactly where to start :( .. my applications have more than 1.000.000 devices with push notifications and I cannot send a push to all in seconds. |
|
@mihai-iorga I believe the scheduling/batching of the push could be better handled. but that would require some changed on parse-server in order for the adapter to run the query, slice it in batches and schedule it properly |
flovilmart
force-pushed
the
improveAPNSBatching
branch
from
3e96048 to
7c0235d
Compare
Fixes #9