Hotfix magic number for magnetic tower donut #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forrestglines
approved these changes
Feb 1, 2024
I saw that error come up out of the blue when I was doing some profiling with the cluster setup yesterday but I didn't look into the cause. Very good that it's found! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there was a hardcoded minimal offset for the donut leftover from original development.
Does not affect our INCITE runs as we ran with an offset of 0.001.
Thanks @mfournier01 for reporting (this came up when the
MagneticTowerModel::PowerSrcTerm mt_linear_contrib and mt_quadratic_contrib are both zero. (Has MagneticTowerReducePowerContribs been called?)safetey check was triggered for offset <0.001).