Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the lock into two locks #1818

Open
ericmnel opened this issue Oct 7, 2021 · 1 comment
Open

Split the lock into two locks #1818

ericmnel opened this issue Oct 7, 2021 · 1 comment
Labels
module: general Related to the PD application in general, or something applicable across multiple modules/apps type: Feature Request make a case for a change to a particular feature or a new feature to be added

Comments

@ericmnel
Copy link

ericmnel commented Oct 7, 2021

Is your feature request related to a problem? Please describe.
Current lock feature is awkward, people are confused by it.

It isn't clear when you are unlocking for staking that it will be unlocked forever, it is strange that there is a time parameter there that is not used even though it looks like it would be.

Because it is a single lock you probably have special code to restore staking unlock after unlocking and locking for something else - I know that there are edge cases where it fails to restore the staking lock.

All that complexity goes away if you just have two separate locks, locking and unlocking staking and wallet seperately.

Describe the solution you'd like
Change to two different locks, one for staking and one for everything else.

@ericmnel ericmnel added the New New issue logged that is waiting for acknowledgement by a responsible person label Oct 7, 2021
@zaSmilingIdiot
Copy link
Collaborator

Noted. And thanks for raising this.
I'll add this to the feature request list for now. There are a couple of additional changes that need to eventually be made, and this would fit in nicely with those changes, so definitely something that can be addressed.

@zaSmilingIdiot zaSmilingIdiot added module: general Related to the PD application in general, or something applicable across multiple modules/apps type: Feature Request make a case for a change to a particular feature or a new feature to be added and removed New New issue logged that is waiting for acknowledgement by a responsible person labels Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: general Related to the PD application in general, or something applicable across multiple modules/apps type: Feature Request make a case for a change to a particular feature or a new feature to be added
Projects
None yet
Development

No branches or pull requests

2 participants