Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fluxv2 addons #25

Merged
merged 4 commits into from
Mar 1, 2021
Merged

feat: add fluxv2 addons #25

merged 4 commits into from
Mar 1, 2021

Conversation

rguichard
Copy link
Member

No description provided.

@rguichard rguichard requested a review from ArchiFleKs February 25, 2021 13:42
@ArchiFleKs
Copy link
Member

Could you implement the create_ns logic on new addition like here and also the label monitoring to not depend on monitoring namespace creation like here

Copy link
Member

@ArchiFleKs ArchiFleKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also missing the default policy that allow its own namespace like in the other files

fluxv2.tf Outdated Show resolved Hide resolved
fluxv2.tf Outdated Show resolved Hide resolved
fluxv2.tf Outdated Show resolved Hide resolved
fluxv2.tf Outdated Show resolved Hide resolved
fluxv2.tf Outdated Show resolved Hide resolved
@ArchiFleKs
Copy link
Member

Finally, I think you should s/fluxv2/flux2 :p

@rguichard
Copy link
Member Author

regarding

resource "kubectl_manifest" "sync" {                                             
  for_each   = { for v in local.sync : lower(join("/", compact([v.data.apiVersion, v.data.kind, lookup(v.data.metadata, "namespace", ""), v.data.metadata.name]))) => v.content }
  depends_on = [kubernetes_namespace.flux2]                                      
  yaml_body  = each.value                                                        
}    

If we use that, this resource will not be created when create_ns = false because the namespace resource won't exist isn't it ?

@ArchiFleKs
Copy link
Member

regarding

resource "kubectl_manifest" "sync" {                                             
  for_each   = { for v in local.sync : lower(join("/", compact([v.data.apiVersion, v.data.kind, lookup(v.data.metadata, "namespace", ""), v.data.metadata.name]))) => v.content }
  depends_on = [kubernetes_namespace.flux2]                                      
  yaml_body  = each.value                                                        
}    

If we use that, this resource will not be created when create_ns = false because the namespace resource won't exist isn't it ?

you mean regarding the depends_on?

@rguichard
Copy link
Member Author

regarding

resource "kubectl_manifest" "sync" {                                             
  for_each   = { for v in local.sync : lower(join("/", compact([v.data.apiVersion, v.data.kind, lookup(v.data.metadata, "namespace", ""), v.data.metadata.name]))) => v.content }
  depends_on = [kubernetes_namespace.flux2]                                      
  yaml_body  = each.value                                                        
}    

If we use that, this resource will not be created when create_ns = false because the namespace resource won't exist isn't it ?

you mean regarding the depends_on?

yes

@ArchiFleKs
Copy link
Member

regarding

resource "kubectl_manifest" "sync" {                                             
  for_each   = { for v in local.sync : lower(join("/", compact([v.data.apiVersion, v.data.kind, lookup(v.data.metadata, "namespace", ""), v.data.metadata.name]))) => v.content }
  depends_on = [kubernetes_namespace.flux2]                                      
  yaml_body  = each.value                                                        
}    

If we use that, this resource will not be created when create_ns = false because the namespace resource won't exist isn't it ?

you mean regarding the depends_on?

yes

Depends_on are not used if the resource is not created like here it works even when kube-prometheus-stack is not enabled

@rguichard rguichard added the enhancement New feature or request label Feb 28, 2021
@rguichard rguichard force-pushed the feat/fluxv2 branch 2 times, most recently from ed55829 to 67966c0 Compare March 1, 2021 12:07
flux2.tf Outdated Show resolved Hide resolved
@mergify mergify bot merged commit dcc89ac into main Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ArchiFleKs ArchiFleKs deleted the feat/fluxv2 branch March 1, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants